Correct error handling to not use BaseException#248
Correct error handling to not use BaseException#248daniel-montanari merged 7 commits intoPyFixate:mainfrom
Conversation
…eption`. No script catches it meaning that if the FTDI driver raises an exception while a power supply is live, it will not be turned off.
…rances of BaseException with Exception. Realistically there is no reason to be using BaseException over Exception unless you want to kill the program.
migrate Riley's work
|
@daniel-montanari and another one for your review please. |
|
@Overlord360 do the excepts for BaseException in main, sequencer.py and common,py need to be changed? Has anyone done any checks with atgrep to make sure there aren't scripts that will break unexpectedly? |
@daniel-montanari As for other test scripts there appear to be four places where BaseException are used in test scripts.
The three uses in the ELV jig use the retry_exceptions variable inherited from the TestClass class in fixate which has been deprecated for 8 years In the Rockstarter protection board test script it's used to create a custom exception. This should be changed to inherit from Exception instead of BaseException. |
daniel-montanari
left a comment
There was a problem hiding this comment.
Looks good just add to release notes please
@daniel-montanari Done! |


Splits off #229 as we don't have push access to Riley's branch / fork.
I've added a top level
FixateErroras per Clint's recommendation in #229