SPD3303x driver bugfix#247
Merged
daniel-montanari merged 8 commits intoPyFixate:mainfrom Feb 27, 2026
Merged
Conversation
… to SPD3303X `save.*` commands
…t e.g; `while pps.ch1.voltage() != 0:...`
…amming it e.g; `while pps.ch1.voltage() != 0:...`" This actually doesn't do anything VISA has a builtin delay set by default for all query's to 100 msec. This reverts commit 481b77a.
Bring in Riley's changes
|
@daniel-montanari another for your review please. |
Collaborator
|
@Overlord360 should we just change the delay default to 0.02 then have everything defined as fixed delay + length delay? Also release notes need a merge |
daniel-montanari
approved these changes
Feb 27, 2026
Collaborator
daniel-montanari
left a comment
daniel-montanari
left a comment
There was a problem hiding this comment.
I'll take that as a no for changing the delay.
Looks good otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forked from #228 as we do not have push access to Riley's fork and/or branch and we need to rerun the checks (but can't do that without committing something)