Skip to content

Fix issues in DMM and PPS tests #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-montanari merged 6 commits into from
Feb 26, 2026
Merged

Fix issues in DMM and PPS tests #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f32ab04
Changed tolerance from 10 mV to 50 mV for Siglent SPD3303X
Sep 19, 2025
2677db8
Increased resistance tolerance from 1 to 5. Marked temperature test a…
Sep 19, 2025
9c7e1da
Increased resistance tolerance from 1 to 5. 'Fixed' floating-point co…
Sep 19, 2025
e114ad7
Merge pull request #1 from Riley-King/fix/test_tolerances
Overlord360 Feb 24, 2026
081fa67
quick fixes as per PR232
Overlord360 Feb 24, 2026
7d7acaf
Update release notes
Overlord360 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/release-notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ Improvements

- Sequencer logic now handles exceptions raised on sequence abort. GUI will no longer hang when a test raises an exception during a test abort.
- Fix bug where DSOX1202G appeared to hang both the program and scope
- LCR Driver now supports instruments reporting as Keysight or Agilent. Newer models of the LCR meter report as Keysight, whereas older models report as Agilent.
- LCR Driver now supports instruments reporting as Keysight or Agilent. Newer models of the LCR meter report as Keysight, whereas older models report as Agilent.
- Changed tolerances for PPS and DMM tests to more accurately match device accuracy.

*************
Version 0.6.4
Expand Down
2 changes: 1 addition & 1 deletion test/drivers/test_fluke_8846A.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# Test values for measurement functions:
# These are mostly defined either by J413 or an arbitrary number I picked.
TEST_RESISTANCE = 100 # Resistance in loopback jig for testing
TEST_RESISTANCE_TOL = 1 # 1 Ohm absolute tolerance
TEST_RESISTANCE_TOL = 5 # 5 Ohm absolute tolerance
TEST_CAPACITANCE = 4.7e-6 # Capacitance in loopback jig for testing
TEST_CAPACITANCE_TOL = 0.5e-6
TEST_VOLTAGE_DC = 100e-3
Expand Down
4 changes: 2 additions & 2 deletions test/drivers/test_keithley_6500.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# Test values for measurement functions:
# These are mostly defined either by J413 or an arbitrary number I picked.
TEST_RESISTANCE = 100 # Resistance in loopback jig for testing
TEST_RESISTANCE_TOL = 1 # 1 Ohm absolute tolerance
TEST_RESISTANCE_TOL = 5 # 5 Ohm absolute tolerance
TEST_CAPACITANCE = 4.7e-6 # Capacitance in loopback jig for testing
TEST_CAPACITANCE_TOL = 0.5e-6
TEST_VOLTAGE_DC = 100e-3
Expand Down Expand Up @@ -57,7 +57,7 @@ def test_reset(dmm):
("capacitance", "CAP"),
("continuity", "CONT"),
("diode", "DIOD"),
("temperature", "TEMP"),
pytest.param("temperature", "TEMP", marks=pytest.mark.xfail),
pytest.param("ftemperature", "TEMP", marks=pytest.mark.xfail),
],
)
Expand Down
2 changes: 1 addition & 1 deletion test/drivers/test_siglent_spd_3303X.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def test_measure_voltage(pps, channel, query, voltage):
time.sleep(1) # Slow PPS again
v = ch.measure.voltage()
ch(False) # Channel ON
assert float(v) == pytest.approx(voltage, abs=10e-3)
assert float(v) == pytest.approx(voltage, abs=50e-3)


# Need to use the patch jig to test any current other than 0.
Expand Down