Closed
Conversation
added 3 commits
September 19, 2025 13:52
…s xfail. 'Fixed' floating-point comparason logic.
Overlord360
suggested changes
Feb 24, 2026
| max_val = values.max | ||
|
|
||
| assert min_val < avg_val < max_val | ||
| assert min_val <= avg_val <= max_val |
Contributor
There was a problem hiding this comment.
In this case we want to check that all three values are not the same. We're measuring a sine wave, if the min and max values are the same then something has gone wrong.
| max_val2 = values.max | ||
|
|
||
| assert min_val2 < avg_val2 < max_val2 | ||
| assert min_val2 <= avg_val2 <= max_val2 |
| max_val = values.max | ||
|
|
||
| assert min_val < avg_val < max_val | ||
| assert min_val <= avg_val <= max_val |
Contributor
There was a problem hiding this comment.
same as the with the fluke we want to check that the values are different
| max_val2 = values.max | ||
|
|
||
| assert min_val2 < avg_val2 < max_val2 | ||
| assert min_val2 <= avg_val2 <= max_val2 |
| # These are mostly defined either by J413 or an arbitrary number I picked. | ||
| TEST_RESISTANCE = 100 # Resistance in loopback jig for testing | ||
| TEST_RESISTANCE_TOL = 1 # 1 Ohm absolute tolerance | ||
| TEST_RESISTANCE_TOL = 5 # 1 Ohm absolute tolerance |
| # These are mostly defined either by J413 or an arbitrary number I picked. | ||
| TEST_RESISTANCE = 100 # Resistance in loopback jig for testing | ||
| TEST_RESISTANCE_TOL = 1 # 1 Ohm absolute tolerance | ||
| TEST_RESISTANCE_TOL = 5 # 1 Ohm absolute tolerance |
Collaborator
|
Because this is in a fork that we don't have access to, this work will continue in #246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed resistance tolerances in keithley 6500 and fluke 8846A tests from 1 ohm to 5 to account for the fact that it is measuring a 100 ohm resistor, fixing it complaining that it got 102 ohms on a two-wire measurement when it expected 100.
Fixed handling of floating-point measurements in keithley 6500 and fluke 8846A tests, changing
min < avg < maxtomin <= avg <= max.Marked temperature test in keithley 6500 as xfail. This is to preserve consistency with the fluke 8846A tests as well as eliminate testing a feature that is not used nor supported.
Changed tolerance in Siglent SPD3303X driver voltage test from 10 mV to 50 mV as that is the limit of the devices precision as guaranteed by Siglent anyway.