Open
Conversation
dougzilla32
force-pushed
the
CoreCancel
branch
from
d502999 to
8091870
Compare
dougzilla32
force-pushed
the
CoreCancel
branch
from
c3ebc12 to
0a19c3e
Compare
dougzilla32
force-pushed
the
CoreCancel
branch
from
fdc186e to
e24ef3c
Compare
dougzilla32
force-pushed
the
CoreCancel
branch
from
e24ef3c to
c6de0ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the diffs for option 1 of Proposal for PromiseKit cancellation support #896. With option 1 the new cancellation code is included with CorePromise.
There repositories involved with the pull request for option 1 are: