Skip to content

Merge changes from IceYGO/master, adding 11 AIs and updating others#44

Open
ChaosCrimson wants to merge 22 commits intoProjectIgnis:masterfrom
ChaosCrimson:master
Open

Merge changes from IceYGO/master, adding 11 AIs and updating others#44
ChaosCrimson wants to merge 22 commits intoProjectIgnis:masterfrom
ChaosCrimson:master

Conversation

@ChaosCrimson
Copy link
Copy Markdown

Merged Executor changes from IceYGO/master related to the following decks:

  • Albaz
  • Apophis
  • Dogmatika
  • Exosister
  • Labrynth
  • Maliss
  • Maliss OCG
  • Ryzeal
  • Superheavy Samurai
  • Yubel
  • Zefra

All projects compile and run, tested on Windows

@edo9300
Copy link
Copy Markdown
Member

edo9300 commented Mar 30, 2026

To not break the ci please revert the changes in the .csproj files that are not related to the actual new decks

@ChaosCrimson
Copy link
Copy Markdown
Author

ChaosCrimson commented Mar 30, 2026

Some of the newer ones like Albaz and Ryzeal use out variable declarations which aren't a part of C# 6. If you want I can try to rewrite the executors to keep using 4.0 or I can just fully update the ci

@edo9300
Copy link
Copy Markdown
Member

edo9300 commented Mar 30, 2026

Some of the newer ones like Albaz and Ryzeal use out variable declarations which aren't a part of C# 6. If you want I can try to rewrite the executors to keep using 4.0 or I can just fully update the ci

keeping net 4.0 as target is required because the project still needs to work on windows XP.
On the c#7 side of the things tho, i actually tried some things, and it seems like that only updating the LangVersion in the csproj works and make things still compile targeting net 4.0 (i don't really know how the c# stuff works).

@edo9300
Copy link
Copy Markdown
Member

edo9300 commented Mar 30, 2026

Some of the newer ones like Albaz and Ryzeal use out variable declarations which aren't a part of C# 6. If you want I can try to rewrite the executors to keep using 4.0 or I can just fully update the ci

keeping net 4.0 as target is required because the project still needs to work on windows XP. On the c#7 side of the things tho, i actually tried some things, and it seems like that only updating the LangVersion in the csproj works and make things still compile targeting net 4.0 (i don't really know how the c# stuff works).

looks like with visual studio 2019 up to c#9 can be targeted, but for now it's better to stick with c#7 only

partially translated comments in YubelExecutor
this was a lazy fix, also forces you to cast anyways if you want to use a logger
fixup setcodes and use longs
@ChaosCrimson ChaosCrimson marked this pull request as ready for review April 13, 2026 14:45
Comment thread ExecutorBase/Game/AI/Executor.cs Outdated
Comment thread bots.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a deck doesn't use links, it should be fine to mark it as mr4 (maybe even 3) as well

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branded seems like it could go in MR3 but not 4 because the mainline combo is Branded Fusion -> Albion dump Lubellion + Albaz -> Searing Lubellion -> Mirrorjade -> GY Lubellion tribute Albion.
A lot of modern combo decks just straight up break without any downward link 2 arrows.

Enums cover up to Limit Over Collection: The Rivals [2026-03-20]
@ChaosCrimson ChaosCrimson requested a review from edo9300 April 15, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants