Skip to content

Fix script execution API error when data and config are sent as JSON arrays #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjacornelius wants to merge 4 commits into
base: develop
Choose a base branch
from
+33 −12
Open

Fix script execution API error when data and config are sent as JSON arrays #8847

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d231f1e
Add getRequestArray helper to ScriptController
sanjacornelius Jun 1, 2026
0097eab
Normalize script input; update OpenAPI types
sanjacornelius Jun 3, 2026
85da842
Update API docs
sanjacornelius Jun 3, 2026
8e3bad8
Revert "Update API docs"
sanjacornelius Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 33 additions & 12 deletions ProcessMaker/Http/Controllers/Api/ScriptController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,11 @@ public function index(Request $request)
* @OA\JsonContent(
* @OA\Property(
* property="data",
* type="array",
* @OA\Items (type="object"),
* type="object",
* ),
* @OA\Property(
* property="config",
* type="array",
* @OA\Items (type="object"),
* type="object",
* ),
* @OA\Property(
* property="code",
Expand All @@ -187,8 +185,8 @@ public function index(Request $request)
*/
public function preview(Request $request, Script $script)
{
$data = json_decode($request->get('data'), true) ?: [];
$config = json_decode($request->get('config'), true) ?: [];
$data = $this->getRequestArray($request->get('data'));
$config = $this->getRequestArray($request->get('config'));
$code = $request->get('code');
$nonce = $request->get('nonce');

Expand All @@ -215,13 +213,11 @@ public function preview(Request $request, Script $script)
* @OA\JsonContent(
* @OA\Property(
* property="data",
* type="array",
* @OA\Items (type="object"),
* type="object",
* ),
* @OA\Property(
* property="config",
* type="array",
* @OA\Items (type="object"),
* type="object",
* ),
* @OA\Property(
* property="sync",
Expand All @@ -245,8 +241,8 @@ public function execute(Request $request, ...$scriptKey)
$processRequest = ProcessRequestToken::findOrFail($request->task_id)->processRequest;
$script = $script->versionFor($processRequest);
}
$data = json_decode($request->get('data'), true) ?: [];
$config = json_decode($request->get('config'), true) ?: [];
$data = $this->getRequestArray($request->get('data'));
$config = $this->getRequestArray($request->get('config'));
$watcher = $request->get('watcher', uniqid('scr', true));
$code = $script->code;

Expand Down Expand Up @@ -561,4 +557,29 @@ public function close(Script $script)

return response([], 204);
}

/**
* Normalize script input before executing the script.
* Script data and config must be an object (associative array), the script
* microservice rejects list payloads like [{}] with a 422.
*/
private function getRequestArray($value): array
{
if (is_string($value)) {
$value = json_decode($value, true);
}

$result = [];

if (is_array($value)) {
if (!array_is_list($value)) {
$result = $value;
} elseif (count($value) === 1 && is_array($value[0])) {
// Unwrap [{}] or [{"key": "value"}] to object form; ignore other lists.
$result = $value[0];
}
}

return $result;
}
}
Loading