chore: ruff F401/F841 + workflow least-privilege (16 CodeQL findings cleared)

.github/workflows/django.yml

@@ -6,6 +6,9 @@ on:
   pull_request:
     branches: ["main", "master"]
 
+permissions:
+  contents: read
+
 jobs:
   build:
     runs-on: ubuntu-latest

.github/workflows/django_ci.yml

@@ -10,6 +10,9 @@ on:
     paths:
       - 'backend/**'
 
+permissions:
+  contents: read
+
 jobs:
   build:
     runs-on: ubuntu-latest

backend/problems/serializers.py

@@ -1,4 +1,3 @@
-from django.conf import settings
 from django.contrib.auth import get_user_model # Import get_user_model
 from rest_framework import serializers
 from .models import Tag, Problem, TestCase

backend/problems/tests.py

@@ -1,3 +1,2 @@
-from django.test import TestCase
 
 # Create your tests here.

backend/problems/views.py

@@ -5,7 +5,7 @@
 from .models import Tag, Problem, TestCase
 from .serializers import TagSerializer, ProblemSerializer, ProblemDetailSerializer, TestCaseSerializer
 from users.models import User
-from users.permissions import IsAdminUser, IsProblemCreator, IsProblemVerifier, ProblemObjectPermissions
+from users.permissions import IsProblemCreator, IsProblemVerifier, ProblemObjectPermissions
 
 
 class TagViewSet(viewsets.ModelViewSet):

backend/submissions/judge_utils/comparison.py

@@ -1,4 +1,3 @@
-import pathlib # Not strictly needed by this function but good for consistency if other utils use it
 from problems.models import Problem # For Problem.ComparisonMode
 
 def compare_outputs(

backend/submissions/judge_utils/execution.py

@@ -1,6 +1,5 @@
 import pathlib
 import subprocess
-import random 
 from django.conf import settings # Import Django settings
 from ..models import Submission 
 

backend/submissions/serializers.py

@@ -1,7 +1,7 @@
 from rest_framework import serializers
 from .models import Submission, SubmissionTestResult # Import SubmissionTestResult
 from users.serializers import UserSerializer 
-from problems.models import Problem, TestCase # Import TestCase for SubmissionTestResultSerializer
+from problems.models import Problem # Import TestCase for SubmissionTestResultSerializer
 
 class SubmissionTestResultSerializer(serializers.ModelSerializer):
     # test_case_id = serializers.ReadOnlyField(source='test_case.id') # Simple ID

backend/submissions/tasks.py

@@ -2,12 +2,8 @@
 from django.db import transaction
 from .models import Submission, SubmissionTestResult # Import SubmissionTestResult
 from problems.models import Problem, TestCase
-import time
-import random
-import subprocess
 import tempfile
 import pathlib
-import shutil
 
 from .judge_utils.comparison import compare_outputs
 from .judge_utils.compilation import compile_code_in_sandbox

backend/submissions/tests.py

@@ -1,3 +1,2 @@
-from django.test import TestCase
 
 # Create your tests here.

backend/users/adapters.py

@@ -1,7 +1,6 @@
 from allauth.account.adapter import DefaultAccountAdapter
 from allauth.socialaccount.adapter import DefaultSocialAccountAdapter
 from django.http import HttpResponseRedirect
-from django.urls import reverse
 
 class CustomAccountAdapter(DefaultAccountAdapter):
     def get_login_redirect_url(self, request):

backend/users/urls.py

@@ -1,6 +1,6 @@
 from django.urls import path, include
 from rest_framework.routers import DefaultRouter
-from .views import UserRegistrationView, PasswordChangeView, UserMeView, AdminUserViewSet, GoogleLogin, GithubLogin, AdminStatsView, UserViewSet
+from .views import UserRegistrationView, PasswordChangeView, UserMeView, AdminUserViewSet, AdminStatsView, UserViewSet
 
 app_name = "users"
 

backend/users/views.py

@@ -40,7 +40,6 @@ class PasswordChangeView(generics.GenericAPIView):
     permission_classes = [permissions.IsAuthenticated]
 
     def post(self, request, *args, **kwargs):
-        user = request.user
         serializer = self.get_serializer(data=request.data, context={'request': request})
         if serializer.is_valid(raise_exception=True):
             serializer.save()