Skip to content

Improve fake controller detection/rejection#10

Merged
kloptops merged 5 commits intoPortsMaster:mainfrom
binarycounter:main
Feb 28, 2026
Merged

Improve fake controller detection/rejection#10
kloptops merged 5 commits intoPortsMaster:mainfrom
binarycounter:main

Conversation

@binarycounter
Copy link
Copy Markdown

Fixes gptk's Xbox mode.

  • Changes device version similar to PR 8 (Fix Inverted D-pad on Some Unity Games by Specifying Xbox 360 Gamepad Version. #8) to fix D-Pad mapping issues
  • Adds BUS_USB bustype because some apps check for this to detect real/virtual controllers
  • Fixes axis order, shouldn't matter in theory, but fixes Joystick API mapping for an unknown reason.
  • Adds a new method for detecting and rejecting our own fake controller. Instead of relying on the device name reported by SDL, we now compare newly added controller to a list of existing controllers added on init. This ensures we ALWAYS detect the fake controller and other (real) Xbox controllers do not get falsely detected.

Tests:
https://docs.google.com/spreadsheets/d/1Kile6xRmJtdSbMaupQgW_iWjoHTZqy0d9_7P_V_f5VU/edit?gid=1043468637#gid=1043468637

@kloptops kloptops merged commit 51b13a5 into PortsMaster:main Feb 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants