Apply platform button mapping in fifo_control mode#318
Open
ArnoldSmith86 wants to merge 1 commit intoPortsMaster:mainfrom
Open
Apply platform button mapping in fifo_control mode#318ArnoldSmith86 wants to merge 1 commit intoPortsMaster:mainfrom
ArnoldSmith86 wants to merge 1 commit intoPortsMaster:mainfrom
Conversation
fix_xbox_mode() and SWAP_BUTTONS were only applied in run(), so the autoinstall dialog had incorrect button mapping on Nintendo-layout devices — pressing A did nothing and B confirmed the dialog instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autoinstall confirm dialog said to press A but that wasn't working. B worked. This is what Claude found. It sounds plausible to me and the fix works on my device. But I don't know the code well enough to know if this is correct.
Claude's suggested PR message:
fix_xbox_mode() and SWAP_BUTTONS were only applied in run(), so the autoinstall dialog had incorrect button mapping on Nintendo-layout devices — pressing A did nothing and B confirmed the dialog instead.