fix: omit user stream market filter for all markets#131
Open
cesarenaldi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marketsfilter when subscribing to all marketsmarkets: [...]Verification
pnpm lintpnpm typecheckpnpm test:clientNotes
Note
Low Risk
Small protocol-shape change for user WebSocket subscribe frames; narrowed subscriptions are unchanged and coverage was added.
Overview
Fixes the initial CLOB user WebSocket subscribe frame so a broad subscription no longer sends a
marketsfield.buildUserSubscribeMessagestill always includes auth andtype: 'user', but it only addsmarketswhenincludeAllMarketsis false. Narrow subscriptions keep sendingmarkets: [...]; all-markets subscriptions match the server expectation of an unfiltered stream (same behavior as the Python SDK fix).Adds a test that subscribing with
{ topic: 'user' }alone produces a frame with auth and type only.Reviewed by Cursor Bugbot for commit 2d3ef79. Bugbot is set up for automated code reviews on this repo. Configure here.