Skip to content

fix: omit user stream market filter for all markets#131

Open
cesarenaldi wants to merge 1 commit into
mainfrom
fix/user-stream-all-markets
Open

fix: omit user stream market filter for all markets#131
cesarenaldi wants to merge 1 commit into
mainfrom
fix/user-stream-all-markets

Conversation

@cesarenaldi

@cesarenaldi cesarenaldi commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Omit the user stream markets filter when subscribing to all markets
  • Keep narrowed user stream subscriptions sending markets: [...]
  • Add coverage for the broad user stream initial subscribe frame

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test:client

Notes


Note

Low Risk
Small protocol-shape change for user WebSocket subscribe frames; narrowed subscriptions are unchanged and coverage was added.

Overview
Fixes the initial CLOB user WebSocket subscribe frame so a broad subscription no longer sends a markets field.

buildUserSubscribeMessage still always includes auth and type: 'user', but it only adds markets when includeAllMarkets is false. Narrow subscriptions keep sending markets: [...]; all-markets subscriptions match the server expectation of an unfiltered stream (same behavior as the Python SDK fix).

Adds a test that subscribing with { topic: 'user' } alone produces a frame with auth and type only.

Reviewed by Cursor Bugbot for commit 2d3ef79. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant