fix: use ?? for autoReconnect default and add onClose/onError callbacks (closes #43)

[Sertug17]

Problem

Two bugs in RealTimeDataClientArgs initialization:

1. autoReconnect: false silently ignored
args!.autoReconnect || true treats false as falsy, so the client
always reconnects regardless of the user's intent.

2. No onClose / onError callbacks
Callers have no way to react to connection drops or errors from
application code. This is the root cause of #26 where streams silently
die after ~20 minutes.

Fix

• Replace || with ?? for autoReconnect default assignment
• Add onClose?: (code: number, reason: string) => void to interface
• Add onError?: (error: ErrorEvent) => void to interface
• Wire both callbacks into the existing onClose and onError handlers

Usage after fix

new RealTimeDataClient({
  autoReconnect: false, // now actually respected
  onClose: (code, reason) => console.log('closed', code, reason),
  onError: (err) => console.error('error', err),
}).connect();

Closes #43
Relates to #26

---

Note

Low Risk
Low risk: small, localized changes to WebSocket lifecycle handling; main impact is altering reconnection behavior when users explicitly set autoReconnect: false.

Overview
Fixes RealTimeDataClient initialization so autoReconnect: false is respected by switching the defaulting logic to ??.

Extends RealTimeDataClientArgs with onClose and onError callbacks and wires them into the existing WebSocket handlers (with try/catch) so callers can react to disconnects and errors.

^{Reviewed by Cursor Bugbot for commit 778a5c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[graphite-app]

If onErrorCallback throws an exception, the autoReconnect logic on line 150 will never execute, breaking automatic reconnection. The callback should be wrapped in a try-catch block:

if (this.onErrorCallback) {
    try {
        this.onErrorCallback(err);
    } catch (e) {
        console.error('Error in onErrorCallback:', e);
    }
}

Suggested change

	if (this.onErrorCallback) {
	this.onErrorCallback(err);
	}
	if (this.autoReconnect) {
	this.connect();
	}
	if (this.onErrorCallback) {
	try {
	this.onErrorCallback(err);
	} catch (e) {
	console.error('Error in onErrorCallback:', e);
	}
	}
	if (this.autoReconnect) {
	this.connect();
	}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

[Sertug17]

Good catch! Wrapped onErrorCallback in a try catch so autoReconnect
always executes regardless of callback behavior. Fixed in 8e8b339.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8e8b339. Configure here.}

[graphite-app]

Unhandled Exception Breaking Auto-Reconnect: The onCloseCallback is invoked without try-catch protection. If the user's callback throws an error, it will prevent the auto-reconnect logic on line 169 from executing.

// Fix: Add try-catch like onError handler does:
if (this.onCloseCallback) {
    try {
        this.onCloseCallback(message.code, String(message.reason));
    } catch (e) {
        console.error('Error in onCloseCallback:', e);
    }
}

This is inconsistent with the onErrorCallback handling (lines 146-152) which correctly wraps the user callback in try-catch.

Suggested change

	if (this.onCloseCallback) {
	try {
	this.onCloseCallback(message.code, String(message.reason));
	if (this.onCloseCallback) {
	try {
	this.onCloseCallback(message.code, String(message.reason));
	} catch (e) {
	console.error('Error in onCloseCallback:', e);
	}
	}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

[Sertug17]

Already fixed in 778a5c4 applied the same try-catch pattern to onCloseCallback as well.