fix(data): parse combo trade activity#100
Merged
cesarenaldi merged 2 commits intoJun 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear
Verification
Note
Low Risk
Additive parsing and typing for combo trades; standard TRADE handling is unchanged aside from an explicit is_combo flag.
Overview
Data API TRADE activity rows with
isCombo: trueare now parsed asComboTradeActivityinstead of failing or mis-mapping CLOB-style fields.parse_activitybranches ontype == "TRADE"andisCombobefore the existing type map. Combo trades useComboConditionId, mapassettoposition_id, and omit CLOB-only fields (outcome, slug, event slug). Standard trades gain an explicitis_combo: falseonTradeActivity.ComboTradeActivityis part of theActivityunion and is re-exported from the public package. Unit coverage was added for combo trade parsing.Reviewed by Cursor Bugbot for commit 20bdcc7. Bugbot is set up for automated code reviews on this repo. Configure here.