Skip to content

Complete empty square brackets of proses#1501

Open
Dropries wants to merge 2 commits intoPokeAPI:masterfrom
Dropries:complete-proses
Open

Complete empty square brackets of proses#1501
Dropries wants to merge 2 commits intoPokeAPI:masterfrom
Dropries:complete-proses

Conversation

@Dropries
Copy link
Copy Markdown
Contributor

Change description

This is a large stylistic PR that aims to ensure that the API return proses in a single language. When a prose contains []{a:b}, this pattern is replaced by b, which exists only in English, resulting in sentences mixing foreign languages and a single English word b.

In each data/v2/csv/~_prose.csv file, I replaced all empty square brackets of the form []{a:b} by [c]{a:b} where c is obtained from the data/v2/csv/a_names.csv file based on the local_language_id of the prose.

A few German []{mechanic:b} are still empty because there is no file containing the translation of mechanics and I don't really know German...

AI coding assistance disclosure

None

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant