Complete empty square brackets of proses#1501
Open
Dropries wants to merge 2 commits intoPokeAPI:masterfrom
Open
Complete empty square brackets of proses#1501Dropries wants to merge 2 commits intoPokeAPI:masterfrom
Dropries wants to merge 2 commits intoPokeAPI:masterfrom
Conversation
0d6f5f0 to
c185a1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
This is a large stylistic PR that aims to ensure that the API return proses in a single language. When a prose contains
[]{a:b}, this pattern is replaced byb, which exists only in English, resulting in sentences mixing foreign languages and a single English wordb.In each
data/v2/csv/~_prose.csvfile, I replaced all empty square brackets of the form[]{a:b}by[c]{a:b}wherecis obtained from thedata/v2/csv/a_names.csvfile based on thelocal_language_idof the prose.A few German
[]{mechanic:b}are still empty because there is no file containing the translation of mechanics and I don't really know German...AI coding assistance disclosure
None
Contributor check list