Add Japanese localization entries for forms and abilities from the latest games#1493
Conversation
Naramsim
left a comment
There was a problem hiding this comment.
Everything seems fine apart from the comment I left. I don't know if we should only use hiragana/katakana for that language id or maybe remove the entries for the language id 1.
| 267,20,12,"兼备蕾冠王的紧张感和 | ||
| 灵幽马的漆黑嘶鸣这两种特性。" | ||
| 267,25,9,This Ability combines the effects of both Calyrex's Unnerve Ability and Spectrier's Grim Neigh Ability. | ||
| 268,25,1,"相手に 触られると |
There was a problem hiding this comment.
Hi, language 1 should be japanese hiragana/katakana only. Maybe these newer games use always kanjis?
There was a problem hiding this comment.
Thanks for pointing that out.
In Sword/Shield, the in-game language selection allowed two Japanese display options.
Available:
- kana-only Japanese text (
ja-hrkt) - standard Japanese text with kanji (
ja)
From Scarlet/Violet onward, the in-game language selection allows only one Japanese display option.
Available:
- standard Japanese text with kanji (
ja)
Not available:
- kana-only Japanese text (
ja-hrkt)
Because of that, my understanding is that the Scarlet/Violet ja-hrkt entries already present in PokeAPI were normalized manually into kana-only Japanese text.
For the data added in this PR, it may be more natural to do the same and rewrite the new ja-hrkt entries manually into kana-only text. Would that be okay?
There was a problem hiding this comment.
OK, I updated the PR so it no longer adds ja-hrkt(1) entries. I expect consumers of newer game data will use ja (11) instead.
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
* chore: store hash and deploy_date into a circleci context * [Updater Bot] Regenerate data from PokeAPI/pokeapi#1493 --------- Co-authored-by: Naramsim <igougi.ui@gmail.com>
Change description
Add Japanese localization entries for Pokemon forms and abilities from the latest games.
This PR includes:
ja/ja-hrktform names for selected Mega and Gigantamax formsThe Japanese entries in this PR were checked against in-game text from Pokemon Scarlet/Violet and Pokemon Champions, as well as official Pokedex pages, for example:
How to test:
make build-dbmake testmake serve/api/v2/pokemon-form/<form>//api/v2/ability/<ability>/AI coding assistance disclosure
I used AI coding assistance to help create small helper scripts for inspecting the repository data, listing Japanese localization entries that were not yet covered for newer game content.
I manually reviewed and edited the final data changes myself, then verified the results locally with:
make build-dbmake testContributor check list