Skip to content

Comments

Migrate from tl_expected to libexpected-dev#151

Open
otamachan wants to merge 1 commit intoPickNikRobotics:mainfrom
otamachan:migrate-tl-expected-to-libexpected-dev
Open

Migrate from tl_expected to libexpected-dev#151
otamachan wants to merge 1 commit intoPickNikRobotics:mainfrom
otamachan:migrate-tl-expected-to-libexpected-dev

Conversation

@otamachan
Copy link

Switch dependency from ROS tl_expected to system libexpected-dev to resolve overlapping header conflicts .

See PickNikRobotics/generate_parameter_library#311

Signed-off-by: Tamaki Nishino <otamachan@gmail.com>
@otamachan
Copy link
Author

Note: Downstream packages that implicitly depend on tl_expected/expected.hpp through RSL headers will need to update their includes to tl/expected.hpp

@christophfroehlich
Copy link
Collaborator

Note: Downstream packages that implicitly depend on tl_expected/expected.hpp through RSL headers will need to update their includes to tl/expected.hpp

I think there isn't much we can do about that. That being said, I think we should do this breaking change only on rolling, including that in ROS Lyrical. Would that work for you?

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (e93c545) to head (b9cd3ea).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   98.65%   98.57%   -0.09%     
==========================================
  Files          11       12       +1     
  Lines         223      210      -13     
  Branches        0       21      +21     
==========================================
- Hits          220      207      -13     
  Misses          3        3              
Flag Coverage Δ
humble ?
rolling 98.57% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants