fix(windows): require VC tools in vswhere discovery#138
Merged
proggeramlug merged 1 commit intoPerryTS:mainfrom Apr 22, 2026
Merged
fix(windows): require VC tools in vswhere discovery#138proggeramlug merged 1 commit intoPerryTS:mainfrom
proggeramlug merged 1 commit intoPerryTS:mainfrom
Conversation
Require `Microsoft.VisualStudio.Component.VC.Tools.x86.x64` in Windows `vswhere` queries so `-latest` no longer resolves SQL Server Management Studio (or any other VS-shell install without MSVC tooling) instead of a real C++ build-tools install. Applies the filtered query to MSVC linker discovery (`find_msvc_link_exe`), MSVC `LIB` path lookup (`find_msvc_lib_paths`), `doctor`'s linker check, and bundled Visual Studio `clang.exe` detection (`find_msvc_bundled_clang`). Adds a Windows-gated regression test pinning the exact `vswhere` arg list so the `-requires` flag can't be silently dropped in a future refactor.
proggeramlug
force-pushed
the
fix/windows-vswhere-vc-tools
branch
from
1cda92b to
76f30c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.VisualStudio.Component.VC.Tools.x86.x64in Windowsvswherequeries so-latestno longer resolves SQL Server Management Studio instead of a real MSVC install.LIBpath lookup,doctor, and bundled Visual Studioclangdetection.vswhereargs to the VC-tools-filtered query.Testing
cargo build -p perrycargo test -p perry-codegen --libcargo test -p perry