Fixed error causing names attribute to be overwritten with NAs#14
Open
cphealy8 wants to merge 3 commits into
Open
Fixed error causing names attribute to be overwritten with NAs#14cphealy8 wants to merge 3 commits into
cphealy8 wants to merge 3 commits into
Conversation
add_landmark_labels is overwriting the names attribute causing the names of landmark entries in the graphml object to be set to NA. This commit prevents this overwriting when it's not needed.
|
@cphealy8 thanks for your feedback to the community I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_landmark_labels is overwriting the names attribute causing the names of landmark entries in the graphml object to be set to NA. This commit prevents this overwriting when it's not needed by wrapping add_landmark_labels in an if-else statement so that this overwriting only occurs when a new variable, overwrite.names, is TRUE.
I added overwrite.names as an optional argument to get_scaffold_map and run_scaffold_analysis with a default value of TRUE.
This implementation should permit the fix without affecting existing deployments of vite.