Skip to content

nand_group_dump: Fix build on clang 16#10

Open
illusionyy wants to merge 1 commit intoPS5Dev:mainfrom
illusionyy:nand-clang-16
Open

nand_group_dump: Fix build on clang 16#10
illusionyy wants to merge 1 commit intoPS5Dev:mainfrom
illusionyy:nand-clang-16

Conversation

@illusionyy
Copy link
Copy Markdown

@illusionyy illusionyy commented Aug 27, 2023

 FAILED: examples/nand_group_dump/CMakeFiles/nand_group_dumper.dir/source/main.c.o 
/opt/hostedtoolcache/llvm-16.0/bin/clang  -isystem /home/runner/work/PS5SDK/PS5SDK -isystem /home/runner/work/PS5SDK/PS5SDK/include --target=x86_64-freebsd-pc-elf -O0 -DPPR -DPS5 -DPS5_FW_VERSION=0x403  -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200112 -D__BSD_VISIBLE=1 -D__XSI_VISIBLE=500 -fno-builtin -nostdlib -Wall -m64 -fomit-frame-pointer -fPIC -fPIE -pie -Wl,-z,norelro -std=gnu11 -MD -MT examples/nand_group_dump/CMakeFiles/nand_group_dumper.dir/source/main.c.o -MF examples/nand_group_dump/CMakeFiles/nand_group_dumper.dir/source/main.c.o.d -o examples/nand_group_dump/CMakeFiles/nand_group_dumper.dir/source/main.c.o -c /home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c
clang-16: warning: -Wl,-z,norelro: 'linker' input unused [-Wunused-command-line-argument]
clang-16: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument]
/home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c:34:9: warning: unused variable 'size' [-Wunused-variable]
        size_t size;
               ^
/home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c:221:57: error: incompatible pointer to integer conversion passing 'int *' to parameter of type 'unsigned long' [-Wint-conversion]
    ret = _ioctl(a53_fd, NAND_A53IO_DISABLE_CONTROLLER, &zero);
                                                        ^~~~~
/home/runner/work/PS5SDK/PS5SDK/ps5/libkernel.h:109:98: note: passing argument to parameter 'data' here
_Fn_(uint64_t   , _ioctl,                               int fd, unsigned long req, unsigned long data);
                                                                                                 ^
/home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c:226:43: error: incompatible pointer to integer conversion passing 'int *' to parameter of type 'unsigned long' [-Wint-conversion]
    ret = _ioctl(a53_fd, NAND_A53IO_OPEN, &zero);
                                          ^~~~~
/home/runner/work/PS5SDK/PS5SDK/ps5/libkernel.h:109:98: note: passing argument to parameter 'data' here
_Fn_(uint64_t   , _ioctl,                               int fd, unsigned long req, unsigned long data);
                                                                                                 ^
/home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c:251:9: warning: ignoring return value of function declared with pure attribute [-Wunused-value]
        memset(out_data, 0, 0x4000000);
        ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c:255:24: error: incompatible pointer to integer conversion assigning to 'uint64_t' (aka 'unsigned long long') from 'void *' [-Wint-conversion]
        ioc_args.p_out = out_data;
                       ^ ~~~~~~~~
/home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c:272:65: error: incompatible pointer to integer conversion passing 'struct ioctl_readnandgroup_args *' to parameter of type 'unsigned long' [-Wint-conversion]
        ret = _ioctl(pupupdate_fd, PUP_UPDATER_READ_NAND_GROUP, &ioc_args);
                                                                ^~~~~~~~~
/home/runner/work/PS5SDK/PS5SDK/ps5/libkernel.h:109:98: note: passing argument to parameter 'data' here
_Fn_(uint64_t   , _ioctl,                               int fd, unsigned long req, unsigned long data);
                                                                                                 ^
/home/runner/work/PS5SDK/PS5SDK/examples/nand_group_dump/source/main.c:52:24: warning: unused variable 'addr' [-Wunused-variable]
    struct sockaddr_in addr;
                       ^
3 warnings and 4 errors generated.

@illusionyy illusionyy mentioned this pull request Aug 27, 2023
@illusionyy illusionyy force-pushed the nand-clang-16 branch 3 times, most recently from d65ce23 to 4162015 Compare August 27, 2023 20:08
@illusionyy
Copy link
Copy Markdown
Author

Also killed some warns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant