Add an option to follow CUI dark/light mode#362
Open
JiayuYangX wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the Columns UI has supported following the system's light and dark color settings in the new version, but the Eole theme does not support this. This experience is somewhat disjointed. This has also be requested formerly in: #248
Therefore, I added an option "Follow CUI dark/light mode" in the skin settings menu, which can switch the skin's color scheme in real time according to the CUI's settings.
However, since the switching is done using the built-in Lightswitch function, in order to enable the Mini Player mode to also switch light/dark mode normally, I modified the response feature of the Mini Player panel to Lightswitch. Now, when you double-click the LightSwitch button, all panels including Mini Player, will switch their color scheme (previously, the light/dark mode of the Mini Player were independent of the "switch all" operation).