Open
Conversation
kylemh
reviewed
Jan 13, 2020
Member
kylemh
left a comment
kylemh
left a comment
There was a problem hiding this comment.
There's a lot going on here, but I'm okay with merging it after these changes.
After we merge the PR, I want to get rid of the stylesheets and instead use Emotion to style things in here. We'll also wanna hide and rotate keys for different tools/API access.
Comment on lines
-5
to
-6
| yarn-debug.log* | ||
| yarn-error.log* |
| @@ -1,5 +0,0 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
we should keep this. It's the config for the local git hooks.
| @@ -1,3 +0,0 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
we should keep this. It's how we defined what files need to be formatted per commit
| @@ -1,3 +0,0 @@ | |||
| trailingComma: "all" | |||
Member
There was a problem hiding this comment.
we should keep this. It will eventually match front-end
| @@ -0,0 +1,148 @@ | |||
| code[class*="language-"], | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses advanced starter for more flexibility. Cypress should still be in there. Pretty sure I got emotion and theme-ui in there as well.
It's ugly, but that means more potential for contribution!