Skip to content

Typed fixed vector#737

Open
wvpm wants to merge 1 commit into
masterfrom
typed_fixed_vector
Open

Typed fixed vector#737
wvpm wants to merge 1 commit into
masterfrom
typed_fixed_vector

Conversation

@wvpm
Copy link
Copy Markdown
Contributor

@wvpm wvpm commented May 15, 2026 •
edited
Loading

  1. Support strongly typed indices in FixedVector
  2. Use index as key instead of pointers
  3. Use FixedVector instead of IndexFlatMap when the key isn't required (only index and value)
  4. Improve FixedVector constructors to be explicit and support moving the vector itself (not the values).

@wvpm wvpm force-pushed the typed_fixed_vector branch 5 times, most recently from 4e64a63 to 3564f97 Compare May 16, 2026 20:20
Spartan322
Spartan322 reviewed May 16, 2026
View reviewed changes
Comment thread src/openvic-simulation/types/FixedVector.hpp Outdated
Spartan322
Spartan322 reviewed May 16, 2026
View reviewed changes
Comment thread src/openvic-simulation/types/FixedVector.hpp Outdated
Spartan322
Spartan322 reviewed May 16, 2026
View reviewed changes
Comment thread src/openvic-simulation/types/FixedVector.hpp Outdated
@wvpm wvpm force-pushed the typed_fixed_vector branch from 9de5c5c to 9c5d824 Compare May 17, 2026 11:46
@wvpm wvpm marked this pull request as ready for review May 17, 2026 11:46
@wvpm wvpm requested a review from a team as a code owner May 17, 2026 11:46
@wvpm wvpm enabled auto-merge May 17, 2026 12:01
@wvpm wvpm added enhancement New feature or request topic:codestyle labels May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Spartan322 Spartan322 Spartan322 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request topic:codestyle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wvpm @Spartan322