docs(analytics): fix dimension availability and label resolution drift#51
docs(analytics): fix dimension availability and label resolution drift#51jtcies wants to merge 2 commits into
Conversation
- Move workspace and app from 31-day to all-time-ranges category (both have MV columns since migration 106) - Add model to label resolution tables (permaslugs are resolved to display names via getModelNamesByPermaslugs) Co-Authored-By: Joseph Ciesielski <joseph.ciesielski@openrouter.ai>
Original prompt from Joseph
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
🚩 Model dimension description says 'permaslug' while label resolution says 'display name'
At skills/openrouter-analytics-schema/SKILL.md:131, the dimension description reads model — the OpenRouter model ID (permaslug), while skills/openrouter-analytics-schema/SKILL.md:118 now says the dimension value is resolved to a display name (e.g., openai/gpt-4o-2024-08-06 → GPT-4o). These are not strictly contradictory — the dimension concept is the model (identified by permaslug) but the response value is a display name — but the juxtaposition could confuse readers. The description at line 131 was not updated to note that the returned value is the resolved display name, not the raw permaslug.
(Refers to line 131)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Fixed in 4de2c30 — clarified the dimension description to note that model is "identified by permaslug; resolved to display name in responses" with a cross-reference to the Label Resolution section above.
…lay names - Response examples now show 'Claude Sonnet 4' / 'GPT-4o' instead of permaslugs, matching the label resolution behavior - Clarify model dimension description: identified by permaslug but resolved to display name in responses Co-Authored-By: Joseph Ciesielski <joseph.ciesielski@openrouter.ai>
There was a problem hiding this comment.
Perry's Review
Adds model to the label-resolved dimensions list across three analytics skill docs, and fixes the time-range category for workspace and app (all-time, not 31-day limited).
Verdict: 🔁 Needs changes
Details
Risk: 🟢 Low
CI: ⏳ 1 pending: perry/review (this review — in progress)
Findings (see inline comment for full context):
- 🟡
skills/openrouter-analytics-schema/SKILL.md:132— dimension description says "permaslug" but label resolution table now says display name
Research: N/A — documentation-only change, trivial tier
Security: no concerns — pure documentation update
Test coverage: N/A — documentation only
Unresolved threads: 2 open Devin threads covering the same inconsistencies; Devin pushed a fix in commit 4de2c30 (on branch, not yet in PR head)
Scope: first review (full)
Review: tier=trivial · model=claude-sonnet-latest · score=0.1
Superseded by updated Perry review
There was a problem hiding this comment.
Perry's Review
Fixes model dimension documentation inconsistency — response examples and label resolution text now consistently show display names, and the dimension description clarifies the permaslug/display-name duality.
Verdict: ✅ LGTM
Details
Risk: 🟢 Low — documentation-only PR, no runtime code changes
CI:
Findings: none
Security: no concerns — documentation only, none of OpenRouter's 8 security categories touched
Test coverage: N/A — SKILL.md documentation, no executable code
Unresolved threads: Devin's thread (unresolved in GitHub UI) confirmed fixed in 4de2c30 by Devin's own reply; Perry's own prior REQUEST_CHANGES thread addressed by this push
Scope: incremental — 4 new lines since prior review
Review: tier=small · model=claude-sonnet-latest · score=0.2
Summary
Two drift items found during daily sync against
openrouter-webquery builder:workspaceandappdimensions were incorrectly categorized under "Limited to 31-day time ranges." Both haveavailableIn: ['mv', 'generations']with MV columns (workspace_id,app_id) since migration 106 — they support up to 365 days. Moved them to the "Available with all time ranges" category.modellabel resolution was missing from all three skills.dimension-labels.tsresolves model permaslugs to display names viagetModelNamesByPermaslugs(e.g.,openai/gpt-4o-2024-08-06→GPT-4o), but the skills said model was "returned as-is without resolution." Addedmodelto label resolution tables in all three skill files.Link to Devin session: https://openrouter.devinenterprise.com/sessions/68368ec02ac04a0c875a6b288a2b19b5
Requested by: @jtcies