Add texture support for DistantLights#17
Open
jlanz wants to merge 1 commit into
Open
Conversation
* Work in progress * Work in progress * Revert * Remove interal 180-degree rotation * Rework introductory comment * Work in progress * Moar work in progress * Bring in line with DiskLight fixes * Working scalar version * Add vector version * Tweak some bits * Remove unused member vars * Apply Copilot feedback * Fix comment * Apply code review feedback * Work on progress on fix for LightFilter issue * Fix assert; add comments * Add comments; remove temp code Signed-off-by: Jon Lanz <jon.lanz@dreamworks.com> MOONRAY-6048 (#2270) * Fix bug * Formatting changes * Vectorise Signed-off-by: Jon Lanz <jon.lanz@dreamworks.com>
jlanz
force-pushed
the
export/MOONRAY-2595
branch
from
ba943a8 to
f334d7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves OpenMoonRay/openmoonray#247
Overview
Adds texture-driven importance sampling and evaluation for DistantLight, enabling textured distant lights with mip- level selection and correct pdf conversion from texture space to spherical-cap solid angle.
Changes:
Filed as internal issues MOONRAY-2595, MOONRAY-6048 (DreamWorks)
Signed-off-by: Jon Lanz jon.lanz@dreamworks.com