Skip to content

Avoid having the version spread everywhere#286

Merged
mgaffigan merged 1 commit intoOpenIntegrationEngine:mainfrom
mgaffigan:maint/avoid-versions-in-code
Apr 14, 2026
Merged

Avoid having the version spread everywhere#286
mgaffigan merged 1 commit intoOpenIntegrationEngine:mainfrom
mgaffigan:maint/avoid-versions-in-code

Conversation

@mgaffigan
Copy link
Copy Markdown
Contributor

Centralizes to the existing mirth-build.properties version property.

Shifts tests to using 99.99.99 as the version to avoid confusion.

@mgaffigan mgaffigan mentioned this pull request Apr 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

Test Results

  111 files  ±0    214 suites  ±0   6m 58s ⏱️ + 1m 6s
  654 tests ±0    654 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 308 runs  ±0  1 308 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 00a8aeb. ± Comparison against base commit be1072d.

@mgaffigan mgaffigan marked this pull request as ready for review April 5, 2026 03:47
Comment thread server/test/resources/notifications-populated.json
Comment thread server/src/com/mirth/connect/connectors/dimse/destination.xml
@jonbartels jonbartels self-requested a review April 7, 2026 23:21
Copy link
Copy Markdown
Contributor

@kryskool kryskool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it works for me

@mgaffigan mgaffigan requested review from a team, NicoPiel, gibson9583, kayyagari, pacmano1, ssrowe and tonygermano and removed request for a team April 14, 2026 18:11
Copy link
Copy Markdown
Member

@tonygermano tonygermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For anyone else searching like I did, this is where the replace happens:

engine/server/build.xml

Lines 444 to 447 in 5203b3a

<!-- set the version on all connectors -->
<replace dir="${extensions}" token="@mirthversion" value="${version}">
<include name="**/*.xml" />
</replace>

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@mgaffigan mgaffigan force-pushed the maint/avoid-versions-in-code branch from 00a8aeb to cfe1e1e Compare April 14, 2026 21:02
@mgaffigan mgaffigan merged commit 49b5884 into OpenIntegrationEngine:main Apr 14, 2026
3 checks passed
@mgaffigan mgaffigan deleted the maint/avoid-versions-in-code branch April 14, 2026 21:02
@tonygermano tonygermano added this to the 4.6.0 milestone Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants