Skip to content

Add platform-common to clippy CI job#5

Merged
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:update-ci
Apr 21, 2026
Merged

Add platform-common to clippy CI job#5
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:update-ci

Conversation

@kurtjd
Copy link
Copy Markdown
Contributor

@kurtjd kurtjd commented Apr 21, 2026

The matrix for the clippy job was missing platform-common which allowed a broken standalone build to slip by. This should catch it from now on.

There are a few other places in various CI jobs we could arguably also add platform-common but I feel like it should be transitively covered by the other platforms, we just want to explicitly check that a standalone build of platform-common has no issues.

@kurtjd kurtjd self-assigned this Apr 21, 2026
Copilot AI review requested due to automatic review settings April 21, 2026 16:40
@kurtjd kurtjd requested a review from a team as a code owner April 21, 2026 16:40
@kurtjd kurtjd added the enhancement New feature or request label Apr 21, 2026
@github-project-automation github-project-automation Bot moved this to In progress in ODP Backlog Apr 21, 2026
@kurtjd kurtjd moved this from In progress to In review in ODP Backlog Apr 21, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI to ensure platform-common is included in the Clippy matrix so regressions in that standalone crate are caught during PR checks.

Changes:

  • Add platform-common to the clippy job matrix in .github/workflows/check.yml.

@jerrysxie jerrysxie merged commit 1733a40 into OpenDevicePartnership:main Apr 21, 2026
34 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in ODP Backlog Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants