Skip to content

Fix issue #402#403

Merged
lohedges merged 1 commit intodevelfrom
fix_402
Jun 12, 2025
Merged

Fix issue #402#403
lohedges merged 1 commit intodevelfrom
fix_402

Conversation

@lohedges
Copy link
Copy Markdown
Contributor

This PR closes #402 by replicating the functionality from the getSystem() method to make sure that systems returned by getFrame() are unsquashed, thus are compatible with the input system used to create the process.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges requested a review from mb2055 June 11, 2025 14:59
@lohedges lohedges self-assigned this Jun 11, 2025
@lohedges lohedges added the bug Something isn't working label Jun 11, 2025
@lohedges lohedges temporarily deployed to biosimspace-build June 11, 2025 14:59 — with GitHub Actions Inactive
@lohedges lohedges had a problem deploying to biosimspace-build June 11, 2025 14:59 — with GitHub Actions Failure
@lohedges lohedges temporarily deployed to biosimspace-build June 11, 2025 14:59 — with GitHub Actions Inactive
@lohedges lohedges had a problem deploying to biosimspace-build June 11, 2025 14:59 — with GitHub Actions Failure
@lohedges lohedges temporarily deployed to biosimspace-build June 11, 2025 14:59 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build June 11, 2025 15:40 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@mb2055 mb2055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@lohedges lohedges merged commit 40c588c into devel Jun 12, 2025
7 of 10 checks passed
@lohedges lohedges deleted the fix_402 branch June 12, 2025 10:06
lohedges added a commit that referenced this pull request Jun 12, 2025
lohedges added a commit that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] BioSimSpace.Process.Amber.getFrame() returns squashed system for FEP

2 participants