Conversation
Contributor
|
Sorry for the delay with this, have been trying to think of a cleaner solution. Two options that I can think of:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #397 .
This fix ensures that each node input file has a unique identifier, preventing conflicts when multiple node instances are running simultaneously.
Fix for the output file is not ideal but I can't think of a better way to do it since we need to read the
file_prefixfrom theargsdictionary without knowing which of the arguments (if any) will be used to set thefile_prefixwhenvalidateis called. The solution here is simply to assume that this will be set using an argument calledfile_prefixand that if this argument does not exist then the default name ofoutput.yamlis used. It does not account for any situation in which thefile_prefixis set using a value that is not thefile_prefixargument.Also adds a
getNodeDirectoryutility function that returns the current value of_node_dir.