Skip to content

Multiple preparations for extended testing#285

Merged
andre-stefanov merged 23 commits into
developfrom
feature/fff-testing
May 14, 2026
Merged

Multiple preparations for extended testing#285
andre-stefanov merged 23 commits into
developfrom
feature/fff-testing

Conversation

@andre-stefanov
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 11, 2026 22:32
@openastrotech-bot
Copy link
Copy Markdown
Contributor

Looks like your PR has code that needs to be changed in order to meet our coding standards!
Here are your options:

  1. Apply the patch that was generated by the job
    1. Click details under the failing clang-format check
    2. Click the Artifacts dropdown in the top right
    3. Download + unzip the clang-format-diff.patch file into the OpenAstroTracker-Firmware repo
    4. Run git apply clang-format-diff.patch to make the changes
    5. Commit and push up the formatted code
  2. Run clang-format locally
    1. Run the command bash -c 'shopt -s nullglob globstar;GLOBIGNORE=./src/libs/TimerInterrupt/*; for i in ./{.,src/**,unit_tests,boards/**}/*.{c,cpp,h,hpp}; do clang-format -i $i; done'
    2. Commit and push up the formatted code

@andre-stefanov
Copy link
Copy Markdown
Member Author

This PR has to be merged AFTER #284

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the repository for more extensive host-based testing by tightening the native PlatformIO test environment, adding coverage tooling/config, and documenting both the workflow and a longer-term refactor/testing plan.

Changes:

  • Hardened the PlatformIO native unit-test environment with stricter warnings and coverage instrumentation.
  • Added gcovr configuration and helper scripts to generate text and HTML coverage reports, plus README instructions.
  • Added an architecture/refactor plan document to guide future work, and small housekeeping updates (.gitignore, unit test main signature).

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
unit_tests/test_common/test_MappedDict.cpp Removes unused argc/argv from the host main() entrypoint for stricter warning builds.
specs/plan.md Adds a detailed clean-architecture refactor & testing roadmap document.
scripts/native_coverage.py Ensures --coverage is applied at link time and disables SCons cache to keep gcov data valid.
scripts/coverage_html.sh Adds a helper script to generate an HTML coverage report via gcovr.
README.md Documents how to run native unit tests and generate coverage reports.
platformio.ini Adds stricter warnings and coverage flags to [env:native] and wires in the coverage extra-script.
gcovr.cfg Adds a gcovr config for consistent coverage output/filtering.
.gitignore Ignores macOS .DS_Store files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread platformio.ini Outdated
Comment thread scripts/coverage_html.sh Outdated
Comment thread specs/plan.md
Comment thread README.md
andre-stefanov and others added 3 commits May 12, 2026 20:31
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ement

- Introduced .clang-format-ignore files to exclude specific directories and files from formatting.
- Added a new script (format.sh) to automate code formatting using clang-format.
- Updated platformio.ini to include environment-specific build flags.
- Cleaned up code formatting in Mount.cpp, Mount.hpp, b_setup.hpp, fonts128x64.h, and other files for consistency.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 16 changed files in this pull request and generated 4 comments.

Comment thread scripts/coverage_html.sh Outdated
Comment thread README.md Outdated
Comment thread src/Mount.hpp
Comment thread unit_tests/test_common/fakes/.clang-format-ignore
@andre-stefanov andre-stefanov enabled auto-merge (squash) May 14, 2026 11:16
Comment thread src/Mount.hpp
@andre-stefanov andre-stefanov merged commit 3452ccc into develop May 14, 2026
8 checks passed
@andre-stefanov andre-stefanov deleted the feature/fff-testing branch May 14, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants