Skip to content

fix(asr): validate MiMo credentials as ASR provider#635

Merged
H-Chris233 merged 1 commit into
Open-Less:betafrom
zouzhe1:fix/mimo-asr-credential-gate
Jun 10, 2026
Merged

fix(asr): validate MiMo credentials as ASR provider#635
H-Chris233 merged 1 commit into
Open-Less:betafrom
zouzhe1:fix/mimo-asr-credential-gate

Conversation

@zouzhe1

@zouzhe1 zouzhe1 commented Jun 10, 2026

Copy link
Copy Markdown

User description

摘要

修复小米 MiMo ASR 已选中后,快捷键启动听写仍误提示检查火山引擎 ASR 凭据的问题。
image

修复 / 新增 / 改进

  • 修复 ensure_asr_credentials()xiaomi-mimo-asr 的凭据分类。
  • 将小米 MiMo ASR 归入 ASR API Key 类型校验,而不是默认落入火山引擎 App Key / Access Key 校验。
  • 新增回归测试,确保 MiMo ASR 不会再被误分类为火山引擎凭据路径。

兼容

  • 不包含:不修改 MiMo ASR 请求协议、不修改设置页字段、不修改火山 / Whisper / 百炼 / 本地 ASR 的运行协议。
  • 对现有用户 / 本地环境 / 构建流程的影响:已选择小米 MiMo ASR 的用户会按 asr.api_key 校验启动听写,不再要求填写火山引擎凭据;其他 ASR provider 行为保持不变。

测试计划

  • 命令:cargo test credential_gate_classifies_mimo_as_api_key_asr_provider --lib

  • 结果:通过,1 passed; 0 failed

  • 证据路径:openless-all/app/src-tauri/src/coordinator/tests.rs

  • 命令:cargo test mimo --lib

  • 结果:通过,7 passed; 0 failed

  • 证据路径:openless-all/app/src-tauri/src/asr/mimo.rs


PR Type

Bug fix, Tests


Description

  • Fix MiMo ASR credential classification

  • Add explicit credential requirement enum

  • Add regression test for MiMo provider


Diagram Walkthrough

flowchart LR
  active_asr["Active ASR Provider"]
  requirement["Credential Requirement"]
  credential_check["Credential Check"]
  active_asr -- "cloud_asr_credential_requirement" --> requirement
  requirement -- "AsrApiKey" --> credential_check
  requirement -- "Volcengine" --> credential_check
Loading

File Walkthrough

Relevant files
Bug fix
asr_setup.rs
Refactor credential gate with enum for providers                 

openless-all/app/src-tauri/src/coordinator/asr_setup.rs

  • Add CloudAsrCredentialRequirement enum and
    cloud_asr_credential_requirement function
  • Refactor ensure_asr_credentials to use enum matching
  • Include MiMo provider in AsrApiKey requirement
+37/-15 
Tests
tests.rs
Add test for MiMo credential classification                           

openless-all/app/src-tauri/src/coordinator/tests.rs

  • Add test credential_gate_classifies_mimo_as_api_key_asr_provider
  • Verify MiMo provider returns AsrApiKey requirement
+8/-0     

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@H-Chris233 H-Chris233 merged commit 4dcd16d into Open-Less:beta Jun 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants