Conversation
Add a local CI script, an installable pre-push hook, and contributor docs so contributors can run the same high-signal format, lint, test, feature-matrix, packaging, and release-bundle checks locally before opening or pushing a PR. Constraint: Local workflow should stay as close to GitHub CI as practical without requiring a perfectly clean working tree Constraint: README-linked contributor docs should also ship in local package and release artifact docs Rejected: Keep pre-push guidance ad hoc in docs only | too easy to skip and drift from CI Confidence: high Scope-risk: narrow Reversibility: clean Directive: When CI steps change, update scripts/local-ci.sh, the hook installer, and contributor docs in the same change Tested: scripts/install-git-hooks.sh; scripts/local-ci.sh; cargo fmt --all -- --check; cargo clippy --all-targets -- -D warnings; cargo test; cargo check --no-default-features; cargo check --no-default-features --features osd; cargo check --no-default-features --features local-rewrite; cargo package --locked --allow-dirty; cargo check --no-default-features --features cuda; cargo check --no-default-features --features cuda,local-rewrite; scripts/build-release-bundle.sh Not-tested: Hook execution from a separate fresh clone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
scripts/install-git-hooks.shscripts/local-ci.shcargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo testcargo check --no-default-featurescargo check --no-default-features --features osdcargo check --no-default-features --features local-rewritecargo package --locked --allow-dirtycargo check --no-default-features --features cudacargo check --no-default-features --features cuda,local-rewritescripts/build-release-bundle.sh