Prefer child exit status over clipboard broken pipe#20
Merged
Conversation
Normalize the clipboard error path so an early child exit that closes stdin reports the child's non-zero status when available instead of racing into a less useful broken-pipe error. Constraint: Success-path clipboard writes must keep failing fast on real stdin write errors Rejected: Keep treating every broken pipe as the primary failure | hides the child's actual non-zero exit in CI Confidence: high Scope-risk: narrow Reversibility: clean Directive: When a child process can exit before stdin is fully written, prefer the final process status if it explains the failure more accurately Tested: cargo test inject::tests:: -- --nocapture; cargo fmt --all -- --check; cargo check --all-targets; cargo clippy --all-targets -- -D warnings; cargo test Not-tested: GitHub Actions rerun still pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo test inject::tests:: -- --nocapturecargo fmt --all -- --checkcargo check --all-targetscargo clippy --all-targets -- -D warningscargo testFollow-up to restore green main CI after the merged stack.