Conversation
|
Start Hyponome locally |
hnrkndrssn
reviewed
Dec 8, 2025
Contributor
hnrkndrssn
left a comment
There was a problem hiding this comment.
there's, what looks like, a debug message on line 255, should this be included?
hnrkndrssn
approved these changes
Dec 9, 2025
hnrkndrssn
approved these changes
Dec 9, 2025
Contributor
hnrkndrssn
left a comment
There was a problem hiding this comment.
I'll mark this as approved and leave it up to you if you want the log message in there or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
grateproject changed the assets for the self-contained versions of the executable. Version1.6.1was the last version the old method was used, the code has been updated to take this into consideration so if the user specifies 1.6.1 or lower, it will use the old method for backwards compatibility when choosing to dynamically download the executable.Results
The template will function correctly when choosing the dynamic download option for the latest versions and remain backwards compatible with 1.6.1
Before
The template was failing when choosing the dynamic download option.
After
Code now executes correctly for new versions as well as 1.6.1 and below.
Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to itFixes an issue I discovered.