Fix extended validation Node setup#135
Merged
Merged
Conversation
Bootstrap shell-safe Node before the fast and extended validation script jobs so scheduled self-hosted runs do not fall back to the runner image's Node 18 runtime. Add workflow coverage for that setup order.
jmcte
force-pushed
the
codex/fix-extended-validation-node
branch
from
a50dfd9 to
65ac37f
Compare
pheidon
approved these changes
Jun 8, 2026
pheidon
left a comment
pheidon
left a comment
Contributor
There was a problem hiding this comment.
Approved: shell-safe Node now boots before the self-hosted validation scripts, which fixes the runner-image Node 18 fallback for the extended validation path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-node.Why
Scheduled Extended Validation on
mainwas runningrun-extended-validation.shunder the self-hosted runner image's Node 18 runtime. Coverage then failed withNo such built-in module: node:inspector/promiseseven though the package requires Node >=20.The first live PR run also showed the trusted self-hosted Linux CI jobs failing in
actions/setup-node@v6while extracting Node becausetarcould not restore archive ownership inside the runner work/temp path. Those jobs now use the repository's shell-safe Node setup action.Verification
pnpm exec vitest run test/workflow.test.ts— passedbash scripts/ci/run-fast-checks.sh— passedLinked issues