[19.0][MIG] base_import_security_group: Migration to 19.0#1274
Open
[19.0][MIG] base_import_security_group: Migration to 19.0#1274
Conversation
This module makes importing data from CSV files optional for each user, allowing it only for those users belonging to a specific group. [FIX] Solved flake8 error E305: expected 2 blank lines after class or function definition, found 1 [FIX] Renamed base_import_csv_optional in base_import_security_group [FIX] Solved flake8 error E501: line too long; [FIX] Removed unnecessary monkeypatch and extended Base.load method; [FIX] Bugfixing in Base.load method; [FIX] Code refactoring [IMP] Tests created
[FIX] Updated travis postgresql version [FIX] Updated phantom_js version in travis [FIX] Configured travis to run tests for this module in isolation mode [FIX] Configured travis to run tests for this module in isolation mode [FIX] Added group to demo_user for test purposes [FIX] Changed waiting condition on Phantom JS test [FIX] Removed Travis configuration for isolated test environment [FIX] Changed waiting condition in phantom_js test [FIX] Changed target action in phantom_js test [FIX] Changed target action in phantom_js test
OCA Transbot updated translations from Transifex [UPD] Update base_import_security_group.pot [UPD] Update base_import_security_group.pot [UPD] README.rst
[UPD] Update base_import_security_group.pot [UPD] README.rst
* Patch existing class instead of duplicating it, for better compatibility with other modules enhancing the same class. * To circumvent problems executing async calls in a non-widget class, pass the user's import permission through the web session. * Adapt tests to consult he Favorite dropdown in the 14.0 GUI. * In the tour, don't target the Users menu which is the default menu of the Settings menu when no other module is installed, and in that case clicking the menu in the tour is a void action that makes the tests fail. Target the Companies menu item instead. [UPD] Update base_import_security_group.pot [UPD] README.rst
[UPD] Update base_import_security_group.pot [UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-15.0/server-ux-15.0-base_import_security_group Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-base_import_security_group/
When the web_responsive module is installed, the tests fail when looking for "Settings" in the menu, because you have to access the menu first to get that option. Adding the extra step to display the menu is the right option so that the tests don't fail whether the web_responsive module is installed or not. TT42822
Currently translated at 100.0% (3 of 3 strings) Translation: server-ux-16.0/server-ux-16.0-base_import_security_group Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_import_security_group/es/
Currently translated at 100.0% (2 of 2 strings) Translation: server-ux-16.0/server-ux-16.0-base_import_security_group Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_import_security_group/it/
Currently translated at 100.0% (3 of 3 strings) Translation: server-ux-18.0/server-ux-18.0-base_import_security_group Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_import_security_group/tr/
tansadio
force-pushed
the
19.0-mig-base_import_security_group
branch
3 times, most recently
from
a3cc66d to
24c4c91
Compare
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! Some minor comments.
tansadio
force-pushed
the
19.0-mig-base_import_security_group
branch
from
24c4c91 to
48b53c5
Compare
OCA-git-bot
added
mod:base_import_security_group
Changes:
- Bump version to 19.0.1.0.0
- Fix `users` → `user_ids` on `res.groups` (XML security)
- Fix `groups_id` → `group_ids` on `res.users` (test)
- Fix `isDisplayed` signature `(config, isSmall)` → `({config, isSmall})` in JS
- Fix tour utils import path `@web_tour/tour_service/tour_utils` → `@web_tour/tour_utils`
- Fix demo user: create test user in setUp (demo data not loaded by default in 19.0)
- Fix `group.users` → `group.user_ids` on `res.groups` (test)
- Fix error message assertion: use `assertIn` for richer Odoo 19 error messages
- Fix KeyError 'nextrow': return complete dict matching load() contract
tansadio
force-pushed
the
19.0-mig-base_import_security_group
branch
from
48b53c5 to
fc1bf41
Compare
Author
|
CI failure caused by Chrome zombie process warnings picked up by oca_checklog_odoo. |
StefanRijnhart
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration from 18.0 to 19.0.
Changes:
users→user_idsonres.groups(XML security)groups_id→group_idsonres.users(test)isDisplayedsignature(config, isSmall)→({config, isSmall})in JS@web_tour/tour_service/tour_utils→@web_tour/tour_utilsgroup.users→group.user_idsonres.groups(test)assertInfor richer Odoo 19 error messages