[IMP] base_tier_validation: add configurable position for reviews widget#1256
Open
[IMP] base_tier_validation: add configurable position for reviews widget#1256
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
Add `_tier_validation_reviews_position` class attribute to the
`TierValidation` mixin to control whether the reviews widget is
rendered at the top or bottom of the form sheet.
Default value is `"bottom"` to preserve existing behavior. Set
`"top"` on any inheriting model to display reviews above all
form fields, which improves usability on mobile views where
scrolling to the bottom is less convenient.
Child models can now configure this per-model:
_tier_validation_reviews_position = "top"
384658b to
7afca41
Compare
Contributor
Author
|
It's missing file DEVELOP.md from https://github.com/OCA/server-ux/tree/18.0/base_tier_validation/readme @LoisRForgeFlow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
_tier_validation_reviews_positionclass attribute to theTierValidationmixin to control whether the reviews widget is rendered at the top or bottom of the form sheet.Default value is
"bottom"to preserve existing behavior. Set"top"on any inheriting model to display reviews above all form fields, which improves usability on mobile views where scrolling to the bottom is less convenient.Child models can now configure this per-model:
This feature was created to position the validation at the top, as when the record description contains a large amount of text, the validation area becomes hard to find. This option is configurable.