[19.0][MIG] partner_deduplicate_by_website#2316
Merged
OCA-git-bot merged 23 commits intoOCA:19.0from Apr 23, 2026
Merged
Conversation
=============================== Deduplicate Contacts by website =============================== This module extends the criteria to match duplicated contacts using the field website. Usage ===== To use this module, you need to: * Go to *Sales > Tools > Deduplicate Contacts*. * Mark "Website" in the section "Search duplicates based on duplicated data in". * This criteria will be used for deduplicating.
- Updated README - Updated views - Improved tests
Currently translated at 100.0% (2 of 2 strings) Translation: crm-11.0/crm-11.0-crm_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-crm_deduplicate_by_website/gl/
…deduplicate_by_website
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_deduplicate_by_website/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-13.0/partner-contact-13.0-partner_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_deduplicate_by_website/es_AR/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_deduplicate_by_website/fr/
Currently translated at 50.0% (1 of 2 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_deduplicate_by_website/it/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_deduplicate_by_website/es/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-17.0/partner-contact-17.0-partner_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_deduplicate_by_website/it/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-18.0/partner-contact-18.0-partner_deduplicate_by_website Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_deduplicate_by_website/sl/
luisDIXMIT
approved these changes
Apr 8, 2026
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM!
| break | ||
| self.assertTrue(found_match) | ||
|
|
||
| def test_deduplicate_by_website_and_is_company(self): |
Contributor
There was a problem hiding this comment.
- Shouldn't this test be named "test_deduplicate_by_website_and_email" instead of "test_deduplicate_by_website_and_is_company", since "is_company" is not actually used here? Or was the intention to test the behavior with 2 company type contacts?
2- Do you think we should add more test cases, like individual vs. company, individual vs. individual, and company vs. company?
They seem to work fine in the UI and are quite similar, but just wanted to confirm.
Otherwise LGTM
Contributor
Author
There was a problem hiding this comment.
I've added is_company now, but the tests are very similar. Not sure if this tests is really needed or should be removed.
CRogos
force-pushed
the
19.0-mig-partner_deduplicate_by_website
branch
from
4ef402a to
1b4cb70
Compare
OCA-git-bot
added
series:19.0
mod:partner_deduplicate_by_website
MohamedOsman7
approved these changes
Apr 23, 2026
Contributor
|
@pedrobaeza could you merge? |
Member
|
/ocabot migration partner_deduplicate_by_website |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 3666220. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.