Skip to content

[MIG] partner_pricelist_tracking: migration to 18.0#2303

Merged
OCA-git-bot merged 4 commits intoOCA:18.0from
jvmntkia:18.0-mig-partner_pricelist_tracking
Apr 27, 2026
Merged

[MIG] partner_pricelist_tracking: migration to 18.0#2303
OCA-git-bot merged 4 commits intoOCA:18.0from
jvmntkia:18.0-mig-partner_pricelist_tracking

Conversation

@jvmntkia
Copy link
Copy Markdown
Contributor

  • Updated manifest version to 18.0.1.0.0
  • Added required OCA fields (images, development_status)
  • Verified compatibility with Odoo 18.0
  • Code already compatible, no API changes needed

@luisDIXMIT
Copy link
Copy Markdown

Hi @jvmntkia , please preserve the commit history following the migration guidelines thanks.

@jvmntkia jvmntkia force-pushed the 18.0-mig-partner_pricelist_tracking branch from 6eebfa8 to 497c97a Compare March 16, 2026 10:36
Copy link
Copy Markdown

@mariancuadranetkia mariancuadranetkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok.

Copy link
Copy Markdown

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested on runboat, LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

"license": "AGPL-3",
"depends": ["product"],
"data": [],
"images": ["static/description/icon.png"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this images key that is as far as I can see completely ignored by Odoo?

Copy link
Copy Markdown
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please do not add useless key to manifest
  • I also do not agree that straightforward technical migration should qualify for adding yourself to contributors list. Your migration will be recognized in the commit history.

@jvmntkia jvmntkia force-pushed the 18.0-mig-partner_pricelist_tracking branch from 497c97a to 2131ef5 Compare April 27, 2026 06:38
@OCA-git-bot OCA-git-bot added series:18.0 mod:partner_pricelist_tracking Module partner_pricelist_tracking labels Apr 27, 2026
@jvmntkia jvmntkia force-pushed the 18.0-mig-partner_pricelist_tracking branch from 2131ef5 to 94b08eb Compare April 27, 2026 07:43
@jvmntkia jvmntkia force-pushed the 18.0-mig-partner_pricelist_tracking branch from 94b08eb to 9bd7c5a Compare April 27, 2026 07:58
@jvmntkia jvmntkia requested a review from NL66278 April 27, 2026 08:04
Copy link
Copy Markdown
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278
Copy link
Copy Markdown
Contributor

NL66278 commented Apr 27, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-2303-by-NL66278-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c58b1b4 into OCA:18.0 Apr 27, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at fec742e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants