[19.0][MIG] mail_activity_team: Migration to 19.0#153
[19.0][MIG] mail_activity_team: Migration to 19.0#153muaazsiddiq wants to merge 81 commits intoOCA:19.0from
Conversation
Currently translated at 100.0% (24 of 24 strings) Translation: social-13.0/social-13.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/it/
When an activity is scheduled due to automatic processes the onchanges won't adapt the proper user team, so we could have a mismatch that provokes an exceptions due to the designed constaints
- If a user is archived but there's an automatic activity, the team check wouldn't locate him. We have to ensure the context. - When the automatic activity gets a user with no team, we should set the team to a void one as well. TT30470
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_activity_team/
If you schedule an activity and you don't force the team as False, errors might araise. For example, on holidays.
Replaced for web_domain_field module
The user couldn't see the proper count of his own activities. It was allways showing the team activities counter. TT35885
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/
Currently translated at 100.0% (35 of 35 strings) Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/
Currently translated at 100.0% (35 of 35 strings) Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/it/
mathiasfrancke
left a comment
mathiasfrancke
left a comment
There was a problem hiding this comment.
One optional change. Tests pending
| # We must consider also users that could be archived but come from | ||
| # an automatic scheduled activity | ||
| if ( | ||
| activity.user_id.id != api.SUPERUSER_ID |
There was a problem hiding this comment.
(optional) we could import SUPERUSER_ID from api so we can use SUPERUSER_ID here instead of api.SUPERUSER_ID
|
@muaazsiddiq Some checks are failing |
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
There are several PR on v18. https://github.com/OCA/mail/pulls?q=is%3Apr+is%3Aopen+mail_activity_team
I think at least the outcome of #116 and #149 should be added before the migration.
Also the changes need to be squashed into one commit and there are also a lot of commits which could be squashed: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
muaazsiddiq
force-pushed
the
19.0-mig-mail_activity_team
branch
from
9d12d79 to
5fe7b94
Compare
|
they are merged now |
muaazsiddiq
force-pushed
the
19.0-mig-mail_activity_team
branch
from
40a92cb to
a7e43b3
Compare
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
- I will add above mentioned PRs once they get merged.
they are merged now
But thy are now part of the Migration commit which is not a good solution and not following the migration guide.
Ok, what do you suggest. Should I do the fresh migration with a new PR or is there any other solution that you would suggest ? |
|
I've created a new PR: #177 |
20 participants
No description provided.