Skip to content

[18.0][MIG]: Migration to 18.0#1565

Open
SMNDVC wants to merge 3 commits intoOCA:18.0from
SMNDVC:18.0-add-hr_employee_digitized_signature
Open

[18.0][MIG]: Migration to 18.0#1565
SMNDVC wants to merge 3 commits intoOCA:18.0from
SMNDVC:18.0-add-hr_employee_digitized_signature

Conversation

@SMNDVC
Copy link
Copy Markdown

@SMNDVC SMNDVC commented Apr 27, 2026

Description

Adds hr_employee_digitized_signature to OCA/hr 18.0, migrated from 16.0.

The module extends hr.employee with a signature binary field and shows it on the employee form (Private Information / Citizenship), after country_of_birth, using the signature widget.

16.0 → 18.0

Bump manifest to 18.0.1.0.0, add summary and application: False (align with other OCA/hr 18 modules).
View: XML header + inherit view technical name hr.employee.view.form.inherit.digitized_signature; keep XML id view_employee_form for upgrade continuity.
Model: fields.Binary(string="Signature"); SPDX-style license line uses https in Python init.
README / static/description / i18n headers updated for 18.0 (OCA links, Weblate project path, Runboat branch).
Register addon in setup/_metapackage/pyproject.toml: odoo-addon-hr_employee_digitized_signature==18.0.*.

@OCA-git-bot OCA-git-bot added mod:hr_employee_digitized_signature Module hr_employee_digitized_signature series:18.0 labels Apr 27, 2026
Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't follow the OCA guidelines, see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

  • need to bring the commit history (follow the step-by-step)
  • need to squash the commits
  • missing pre-commit auto-fixes commit
  • rename the mig commit message
  • rename the PR title

@SMNDVC SMNDVC force-pushed the 18.0-add-hr_employee_digitized_signature branch from 9e48419 to ddd489c Compare May 4, 2026 13:37
@SMNDVC SMNDVC changed the title [MIG] hr_employee_digitized_signature [18.0][MIG]: Migration to 18.0 May 4, 2026
@SMNDVC
Copy link
Copy Markdown
Author

SMNDVC commented May 4, 2026

Hi. I went through the 18.0 migration guide and tried to fix everything you pointed out: replayed the module history with format-patch / git am, squashed the noisy commits, added the [IMP] pre-commit auto fixes commit after running pre-commit, used [MIG] hr_employee_digitized_signature: Migration to 18.0 for the migration commit, and updated the PR title to [18.0][MIG]: Migration to 18.0.

Note: this module isn’t on OCA 17.0, so I replayed from the last branch where it still exists.

I hope thats all I was supossed to do and thanks again for the review.

Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change the PR title from [18.0][MIG]: Migration to 18.0 to [18.0][MIG] hr_employee_digitized_signature: Migration to 18.0
  • The noise commits like translation commits can be squashed but it's not the real problem (you can left then if you want), but there are missing important commits history like f46ce88 and 39d5630

Ps: migrate from 16.0 to 18.0 it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:hr_employee_digitized_signature Module hr_employee_digitized_signature series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants