Conversation
There was a problem hiding this comment.
This PR doesn't follow the OCA guidelines, see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
- need to bring the commit history (follow the step-by-step)
- need to squash the commits
- missing pre-commit auto-fixes commit
- rename the mig commit message
- rename the PR title
9e48419 to
ddd489c
Compare
|
Hi. I went through the 18.0 migration guide and tried to fix everything you pointed out: replayed the module history with format-patch / git am, squashed the noisy commits, added the [IMP] pre-commit auto fixes commit after running pre-commit, used [MIG] hr_employee_digitized_signature: Migration to 18.0 for the migration commit, and updated the PR title to [18.0][MIG]: Migration to 18.0. Note: this module isn’t on OCA 17.0, so I replayed from the last branch where it still exists. I hope thats all I was supossed to do and thanks again for the review. |
WesleyOliveira98
left a comment
There was a problem hiding this comment.
- Change the PR title from
[18.0][MIG]: Migration to 18.0to[18.0][MIG] hr_employee_digitized_signature: Migration to 18.0 - The noise commits like translation commits can be squashed but it's not the real problem (you can left then if you want), but there are missing important commits history like f46ce88 and 39d5630
Ps: migrate from 16.0 to 18.0 it's fine
Description
Adds hr_employee_digitized_signature to OCA/hr 18.0, migrated from 16.0.
The module extends hr.employee with a signature binary field and shows it on the employee form (Private Information / Citizenship), after country_of_birth, using the signature widget.
16.0 → 18.0
Bump manifest to 18.0.1.0.0, add summary and application: False (align with other OCA/hr 18 modules).
View: XML header + inherit view technical name hr.employee.view.form.inherit.digitized_signature; keep XML id view_employee_form for upgrade continuity.
Model: fields.Binary(string="Signature"); SPDX-style license line uses https in Python init.
README / static/description / i18n headers updated for 18.0 (OCA links, Weblate project path, Runboat branch).
Register addon in setup/_metapackage/pyproject.toml: odoo-addon-hr_employee_digitized_signature==18.0.*.