[18.0][IMP] hr_employee_second_lastname: Add new name order format "Lastname, Firstname SecondLastname"#1554
Open
BhaveshHeliconia wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
|
Hi @luisg123v, |
|
|
||
| order = self._get_names_order() | ||
|
|
||
| if order == "last_first_comma2": |
There was a problem hiding this comment.
why not put this algorithm in _get_inverse_name.
Contributor
Author
There was a problem hiding this comment.
Could you please elaborate on what you meant? I think I've already placed this logic inside _get_inverse_name. Maybe I'm missing something or misunderstanding your point.
There was a problem hiding this comment.
I mean, in the "original function", not the overloaded one.
Contributor
Author
There was a problem hiding this comment.
We can't because 'lastname2' field is introduced in 'hr_employee_second_lastname' module and we've used this field in this new name format
Contributor
Author
There was a problem hiding this comment.
Thanks for confirming 🙂
BhaveshHeliconia
force-pushed
the
18.0-imp-hr_employee_second_lastname
branch
from
3cd6c9c to
007dec8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new name order format for employees: Lastname, Firstname SecondLastname (e.g., Fernandez, Manuel Gonzalez).
Changes: