forked from robinebers/openusage
-
Notifications
You must be signed in to change notification settings - Fork 0
Windows support groundwork (#77) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Noisemaker111
wants to merge
18
commits into
main
Choose a base branch
from
Windows-Support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bc1d540
feat: add full Windows system tray support (#77)
Noisemaker111 df6fd5c
feat: stabilize Windows UX for testers
Noisemaker111 f3de4ab
fix: harden Windows support plumbing
Noisemaker111 dc88be4
ci: prep Windows signing hooks
Noisemaker111 6735290
fix: address PR77 review regressions
Noisemaker111 d55c20b
fix: embed sqlite for plugin host
Noisemaker111 29e5395
fix: replace wmic process listing
Noisemaker111 7217db4
fix: add Windows DPAPI vault
Noisemaker111 672a781
ci: enforce Windows signing secrets
Noisemaker111 828edf9
fix: improve Windows tray icon contrast
Noisemaker111 14a2e6b
fix: restore Linux placeholders
Noisemaker111 12d1c85
fix: scope gh token parsing
Noisemaker111 3f6f44d
merge: update from upstream/main (30+ commits behind)
Noisemaker111 3e8e3b7
feat(codex): surface GPT-5.3-Codex-Spark per-model rate limits (#176)
robinebers 6ca4794
fix(codex): replace var with const/let in rate-limit loop
robinebers abe3f24
chore: bump version to 0.6.3
robinebers 8467d87
Merge branch 'upstream/main' into Windows-Support
Noisemaker111 ae4445b
feat: add Windows build support to release workflow
Noisemaker111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| # Owner Guide: Windows Release Setup | ||
|
|
||
| Generate Windows certificate from your Mac, add GitHub secrets, push a tag. | ||
|
|
||
| ## 1. Generate Windows Certificate | ||
|
|
||
| Install OpenSSL if not present: | ||
|
|
||
| ```bash | ||
| brew install openssl | ||
| ``` | ||
|
|
||
| Create certificate: | ||
|
|
||
| ```bash | ||
| # Create private key | ||
| openssl genrsa -out windows.key 4096 | ||
|
|
||
| # Create certificate | ||
| openssl req -new -x509 -key windows.key -out windows.crt -days 365 \ | ||
| -subj "/CN=Sunstory/O=Sunstory/C=US" | ||
|
|
||
| # Convert to PFX | ||
| openssl pkcs12 -export -out codesign.pfx -inkey windows.key -in windows.crt | ||
| # Enter password when prompted (save this!) | ||
| ``` | ||
|
|
||
| For production: Buy a certificate from DigiCert/Sectigo instead. | ||
|
|
||
| ## 2. Encode for GitHub Secrets | ||
|
|
||
| ```bash | ||
| # Base64 encode | ||
| cat codesign.pfx | base64 > cert_base64.txt | ||
|
|
||
| # Copy to clipboard (macOS) | ||
| cat cert_base64.txt | pbcopy | ||
|
|
||
| # Cleanup sensitive files | ||
| rm windows.key windows.crt codesign.pfx | ||
| ``` | ||
|
|
||
| ## 3. Add GitHub Secrets | ||
|
|
||
| Go to: `https://github.com/robinebers/openusage/settings/secrets/actions` | ||
|
|
||
| Add: | ||
|
|
||
| | Secret | Value | | ||
| |--------|-------| | ||
| | `WINDOWS_CERTIFICATE` | Paste from clipboard (base64) | | ||
| | `WINDOWS_CERTIFICATE_PASSWORD` | Password from step 1 | | ||
|
|
||
| ## 4. Update Versions | ||
|
|
||
| Set same version in all 3 files: | ||
|
|
||
| ```bash | ||
| # Check current | ||
| grep '"version"' package.json src-tauri/tauri.conf.json | ||
| grep '^version' src-tauri/Cargo.toml | ||
|
|
||
| # Edit files (use your editor) | ||
| cursor src-tauri/tauri.conf.json # "version": "0.6.4" | ||
| cursor src-tauri/Cargo.toml # version = "0.6.4" | ||
| cursor package.json # "version": "0.6.4" | ||
| ``` | ||
|
|
||
| ## 5. Create Release | ||
|
|
||
| ```bash | ||
| # Commit | ||
| git add src-tauri/tauri.conf.json src-tauri/Cargo.toml package.json | ||
| git commit -m "chore: release v0.6.4" | ||
|
|
||
| # Push | ||
| git push origin main | ||
|
|
||
| # Tag | ||
| git tag v0.6.4 | ||
| git push origin v0.6.4 | ||
| ``` | ||
|
|
||
| ## 6. Monitor Build | ||
|
|
||
| ```bash | ||
| # Watch workflow | ||
| gh run watch | ||
|
|
||
| # Or open browser | ||
| open "https://github.com/robinebers/openusage/actions" | ||
| ``` | ||
|
|
||
| ## 7. Verify | ||
|
|
||
| ```bash | ||
| # Check release assets | ||
| gh release view v0.6.4 | ||
| ``` | ||
|
|
||
| Should have: | ||
| - `OpenUsage_0.6.4_aarch64.dmg` | ||
| - `OpenUsage_0.6.4_x64.dmg` | ||
| - `OpenUsage_0.6.4_x64_en-US.msi` (Windows) | ||
| - `OpenUsage_0.6.4_x64-setup.exe` (Windows) | ||
| - `latest.json` | ||
|
|
||
| ## Troubleshooting | ||
|
|
||
| **Missing WINDOWS_CERTIFICATE** | ||
| - Check secret exists in GitHub → Settings → Secrets | ||
|
|
||
| **Version mismatch** | ||
| - All 3 files must have same version number | ||
|
|
||
| **No Windows assets** | ||
| - Check workflow logs for Windows build errors | ||
| - Verify `WINDOWS_CERTIFICATE_PASSWORD` is correct | ||
|
|
||
| ## Commands Reference | ||
|
|
||
| ```bash | ||
| # Check versions | ||
| grep -h version package.json src-tauri/tauri.conf.json src-tauri/Cargo.toml | ||
|
|
||
| # List releases | ||
| gh release list | ||
|
|
||
| # View workflow runs | ||
| gh run list --workflow=publish.yml | ||
|
|
||
| # Check specific run | ||
| gh run view <run-id> | ||
| ``` |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Breadcrumbs | ||
|
|
||
| ## 2026-02-09 | ||
|
|
||
| - Windows dev: align AppState plugin/probe types with LoadedPlugin + PluginOutput, and persist arrow offset for tray alignment fallback. | ||
| - Arrow alignment: account for panel horizontal padding when positioning tray arrow. | ||
| - Side taskbar: compute arrow offset on Y axis and render left/right arrows. | ||
| - Side taskbar: use work area bounds to avoid overlapping the taskbar. | ||
| - Windows plugin scan: identified OS path/keychain blockers per plugin. | ||
| - Windows plugins: add Windows path candidates for Codex/Claude/Cursor/Windsurf and guard keychain usage to macOS. | ||
| - Windows OS gating: enable windows in plugin manifests and add actionable missing-path errors for testers. | ||
| - Cleanup: moved `WINDOWS_CHANGES.md` and reserved `nul` file to trash; kept `src/contexts/taskbar-context.tsx` for later wiring. | ||
| - Windows updater: documented that production updates require Authenticode signing; marked current state as test-only. | ||
| - Windows signing: added conditional PFX import step and owner follow-up checklist. | ||
| - Cleanup: removed unused `src/contexts/taskbar-context.tsx`. | ||
| - PR 77 fixes: re-enabled tray icon updates, restored Linux tray click handling, guarded window clamp, and replaced env-based Windows probes with `~`-based paths under a CODEX_HOME-only allowlist. | ||
|
|
||
| ## 2026-02-10 | ||
|
|
||
| - Switched plugin host sqlite to embedded `rusqlite` with bundled SQLite for cross-platform availability. | ||
| - Replaced Windows process discovery `wmic` with PowerShell CIM JSON parsing in `src-tauri/src/plugin_engine/host_api.rs`. | ||
| - Added Windows DPAPI-backed `host.vault` and updated Copilot auth to use it. | ||
| - Enforced Windows signing secrets in publish workflow to prevent unsigned releases. | ||
| - Adjusted dynamic tray icon rendering to stay visible on dark Windows taskbars. | ||
| - Restored Linux placeholders for tray positioning and plugin availability. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 CI workflow uses non-existent GitHub Action
dtolnay/rust-actionThe CI workflow references
dtolnay/rust-action@stablewhich does not exist. The correct action name isdtolnay/rust-toolchain@stable, as correctly used in the publish workflow at.github/workflows/publish.yml:37.Impact
The CI workflow will fail on every PR for both ubuntu-latest and windows-latest matrix entries because the
Install Rust toolchainstep will fail to find the action. This blocks all CI checks.Was this helpful? React with 👍 or 👎 to provide feedback.