[codex] Add eShopOnWeb feature comparison plans#21
[codex] Add eShopOnWeb feature comparison plans#21KyleMcMaster wants to merge 2 commits intomainfrom
Conversation
KyleMcMaster
changed the title
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
There was a problem hiding this comment.
Pull request overview
Adds a structured parity assessment and a set of sequential planning documents to track remaining feature gaps between FShopOnWeb (F#) and NimblePros/eShopOnWeb (C#), including a recommended implementation order based on dependencies.
Changes:
- Added a feature comparison matrix summarizing implementation status and linking each gap to a numbered plan.
- Added detailed plan documents (0001–0010) covering missing/partial feature areas (identity, orders, admin, API, migrations, operability, tests).
- Documented a recommended delivery order to guide follow-up implementation work.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/plans/0000-feature-comparison.md | Feature matrix + evidence summary + recommended delivery order linking into the detailed plans. |
| docs/plans/0001-storefront-parity.md | Plan for catalog filtering/pagination and basket ownership/quantity parity. |
| docs/plans/0002-authentication-and-account-flows.md | Plan for implementing real authentication, registration, logout, and authorization guards. |
| docs/plans/0003-github-sso.md | Plan for adding GitHub OAuth after baseline identity is in place. |
| docs/plans/0004-checkout-and-orders.md | Plan for checkout workflow, order persistence, and order history pages. |
| docs/plans/0005-admin-catalog-management.md | Plan for role-protected catalog administration features. |
| docs/plans/0006-user-and-role-administration.md | Plan for user/role CRUD and role membership management with safeguards. |
| docs/plans/0007-public-api.md | Plan for a public JSON API surface (catalog + auth + admin endpoints) and testing expectations. |
| docs/plans/0008-database-migrations-and-seeding.md | Plan for migrations, non-destructive startup, and idempotent seeding to support downstream features. |
| docs/plans/0009-operability-and-observability.md | Plan for health checks, exception handling/diagnostics, and minimal ops documentation. |
| docs/plans/0010-test-strategy.md | Plan for expanding automated test coverage and defining suite/CI expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8f5a7ebab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What changed
FShopOnWebandNimblePros/eShopOnWebdocs/plansfor each feature area that is partial or missing in the F# portWhy
The F# port needed a concrete parity assessment against the current C# reference implementation and a trackable plan for closing the gaps.
Highlights
docs/plans/0000-feature-comparison.mdcontains the feature matrix and implementation status for both repositoriesdocs/plans/0001through0010break the major missing areas into tracked work items:Impact
test breadth
Validation
NimblePros/eShopOnWebsourcedocs/plansfiles were created and committed locally