feat: set default HSTS and CSP headers for direct-exposure deployments (#14)#20
Open
mgoldsborough wants to merge 1 commit intomainfrom
Open
feat: set default HSTS and CSP headers for direct-exposure deployments (#14)#20mgoldsborough wants to merge 1 commit intomainfrom
mgoldsborough wants to merge 1 commit intomainfrom
Conversation
#14) The previous stance of "HSTS/CSP belong on the reverse proxy" leaves self-hosted OSS deployments with no hardening when no proxy sits in front. Direct-exposure HTTPS is a supported topology, so the defaults should protect it. Add conservative defaults in securityHeaders(): - HSTS: max-age=31536000; includeSubDomains (no preload — that is a deliberate operator choice) - CSP: default-src 'none'; frame-ancestors 'none'; base-uri 'none' (no effect on JSON/SSE; bundle UI HTML is consumed via fetch+srcdoc so the response CSP does not break the iframe bridge, but does protect anyone opening that HTML directly) Operators who terminate TLS at a proxy that already emits these headers can disable them with NB_HSTS="" / NB_CSP="", or override to a stricter/looser value via env var or the middleware option. Env var takes precedence over option so ops can change the runtime policy without a code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #14