fix: return generic error for workspace resolution failures (#17)#19
Open
mgoldsborough wants to merge 1 commit intomainfrom
Open
fix: return generic error for workspace resolution failures (#17)#19mgoldsborough wants to merge 1 commit intomainfrom
mgoldsborough wants to merge 1 commit intomainfrom
Conversation
Workspace resolution previously returned distinct responses for non-existent workspaces (400, "Workspace \"ws_x\" not found") and unauthorized access (403, "Access denied: not a member of ws_x"). The combination of distinct status codes and ID-bearing messages let any authenticated caller probe for workspace existence and membership. Collapse both to a single generic 403 "Access denied to workspace." with no workspace ID echo. Input validation paths (invalid format, multiple-workspace ambiguity) are untouched — they do not signal existence of other tenants' workspaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
400, "Workspace "ws_x" not found") vs unauthorized access (403, "Access denied: not a member of ws_x"). The combination of status codes and ID-bearing messages let any authenticated caller probe for workspace existence and membership.403with the generic message"Access denied to workspace."and no workspace ID echo. Input validation paths (invalid format, multiple-workspace ambiguity) are left alone — they do not signal existence of other tenants' workspaces.Test plan
Closes #17