Support spawn_connected rules for waterbody-adjacent spawning#155
Merged
NewGraphEnvironment merged 3 commits intomainfrom Apr 14, 2026
Merged
Support spawn_connected rules for waterbody-adjacent spawning#155NewGraphEnvironment merged 3 commits intomainfrom
NewGraphEnvironment merged 3 commits intomainfrom
Conversation
Relates to #154 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add spawn_connected as a valid habitat block alongside spawn/rear. Unlike spawn/rear (lists of rules with OR semantics), spawn_connected is a single configuration block with fixed keys: direction, waterbody_type, gradient_max, channel_width_min, distance_max, bridge_gradient. Own validation via .frs_validate_spawn_connected(). Flows through existing params attachment — accessible at params$SP$rules$spawn_connected. Relates to #154 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
After the subtractive phases (downstream trace + upstream cluster), Phase 3 promotes accessible segments in the downstream trace that meet permissive spawn_connected thresholds (gradient_max, channel_width_min, edge_types) but failed standard classification. Keeps lfid_tbl alive from Phase 1 for the additive UPDATE. Segments must be accessible, in the trace, and meet all spawn_connected predicates. Wired through dispatcher via params$rules$spawn_connected. BULK SK spawning: 22.04 km → ~24.2 km (bcfishpass 24.38 km). Relates to #154 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_connectedblock in rules YAML — single config block with fixed keys (direction,waterbody_type,gradient_max,channel_width_min,distance_max,bridge_gradient), own validation separate from spawn/rear rules.frs_connected_waterbody(): after subtractive phases, promote accessible segments in the downstream trace that meet permissive spawn_connected thresholds but failed standard classificationTest plan
link@31-per-model-barrierscompare_bcfishpass.R on BULKFixes #154
Relates to NewGraphEnvironment/sred-2025-2026#16
🤖 Generated with Claude Code