Fix Wairagkar2018 dataset zip extraction#1066
Open
baris-talar wants to merge 2 commits intoNeuroTechX:developfrom
Open
Fix Wairagkar2018 dataset zip extraction#1066baris-talar wants to merge 2 commits intoNeuroTechX:developfrom
baris-talar wants to merge 2 commits intoNeuroTechX:developfrom
Conversation
safe_extract_zip() expects a zipfile.ZipFile object and a Path, but was being called with two string paths, causing extraction to fail on first download. Add import zipfile and wrap the call correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
It looks like the CI workflows are awaiting approval. Could someone approve and trigger them for this PR? Thanks! |
Collaborator
|
can you please fix the whats new file? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Wairagkar2018 dataset zip extraction
Related to #904
This PR fixes an issue in the Wairagkar2018 dataset loader where
safe_extract_zipwas called with incorrect argument types, causingthe dataset extraction to fail on first download.
Issue
safe_extract_zipexpects azipfile.ZipFileobject and aPath, butit was being called with string paths instead. As a result, the zip file
was not properly opened before extraction, leading to failures when
loading the dataset.
Fix
import zipfile