Skip to content

E2E optimizations and tweaks#176

Merged
frozenspider merged 8 commits intomainfrom
feature/more-optimizations
May 8, 2026
Merged

E2E optimizations and tweaks#176
frozenspider merged 8 commits intomainfrom
feature/more-optimizations

Conversation

@frozenspider
Copy link
Copy Markdown
Collaborator

@frozenspider frozenspider commented Apr 21, 2026

  1. In MLE-first approach, when the ideal is zero, the ideal check computation can be skipped - we know that the MLE evaluation is supposed to be 0, so P does not need to compute it: it just sends 0.
    • This only allows skippping MLE evaluation if ALL ideals are 0.
    • In combined polynomial ideal check, this was already handled but with more granularity - all zero ideal constraints were skipped while keeping non-zero ones.
  2. Reworked MLE-first approach to handle linear constraints in MLE-first way while the rest are going through the regular combined subroutine. This allows using MLE-first approach for UAIRs with non-linear constraints.
  3. Use IPRS code with rate 1/8 instead of 1/4, while also lowering number of column openings to 100 instead of 147.

Overall effect on E2E benchmarks (2^8 vars, parallel mode):

  • Prover time (both combined and MLE-first) stayed pretty much the same
  • Verifier time worsened by around to ~10%
  • Proofs became smaller by ~30-40%, both compressed and uncompressed

@frozenspider frozenspider force-pushed the feature/more-optimizations branch from ba6c8f6 to 64c6b38 Compare April 21, 2026 11:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Coverage (base → head): 87.55% → 87.28% ⬇️ 0.27 pp
Only posts when PR coverage is lower than the base branch's latest push (or freshly computed base).

@frozenspider
Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64c6b38e58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread piop/src/ideal_check.rs Outdated
@frozenspider frozenspider marked this pull request as ready for review April 21, 2026 12:41
@frozenspider frozenspider force-pushed the feature/more-optimizations branch from c4b1579 to 2b81a47 Compare May 7, 2026 19:28
@frozenspider frozenspider merged commit 285d2d9 into main May 8, 2026
10 of 11 checks passed
@frozenspider frozenspider deleted the feature/more-optimizations branch May 8, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant