Skip to content

new canary workflow & stylelint-config#111

Merged
yceffort-naver merged 7 commits intomainfrom
feature/110
May 20, 2025
Merged

new canary workflow & stylelint-config#111
yceffort-naver merged 7 commits intomainfrom
feature/110

Conversation

@yceffort-naver
Copy link
Copy Markdown
Contributor

This pull request introduces several updates, including the addition of a new GitHub Actions workflow for Canary releases, renaming and updating the release workflow, and dependency updates across multiple files. Below is a breakdown of the key changes:

GitHub Actions Workflows

  • New Canary Release Workflow: Added a new workflow (.github/workflows/canary.yml) triggered by specific issue comments (canary-publish or /canary-publish) to automate Canary releases. It includes steps for checking out the PR branch, setting up Node.js and pnpm, and publishing the Canary version using a specified script.
  • Renamed and Updated Release Workflow: Renamed .github/workflows/changeset-publish.yml to .github/workflows/release.yml and updated its configuration. Changes include renaming the job from publish to release, improving step names for clarity, and updating the changeset-actions/publish configuration with corrected parameters and formatting. [1] [2]

Dependency Updates

  • package.json Update: Updated the vite dependency from version ^6.2.0 to ^6.3.5.
  • packages/stylelint-config/package.json Updates:
    • Moved postcss and postcss-scss to peerDependencies with updated versions.
    • Updated stylelint, stylelint-order, and stylelint-scss to newer versions under dependencies.

@yceffort-naver yceffort-naver self-assigned this May 19, 2025
@yceffort-naver yceffort-naver requested a review from a team as a code owner May 19, 2025 01:08
@yceffort-naver
Copy link
Copy Markdown
Contributor Author

/canary-publish

@yceffort-naver yceffort-naver changed the title new canary worrkflow & stylelint-config new canary workflow & stylelint-config May 19, 2025
@yceffort-naver
Copy link
Copy Markdown
Contributor Author

@yujeong-jeon , Could you help me figure out what’s causing the issue? I just pushed two new commits. 🤔

NaverPayDev/changeset-actions@c46d567
NaverPayDev/changeset-actions@b7cc609

@yceffort-naver
Copy link
Copy Markdown
Contributor Author

Looks like there are two issues here—one related to the default export, and the other has something to do with the GitHub path. 🤔 @yujeong-jeon

@npayfebot
Copy link
Copy Markdown
Contributor

npayfebot commented May 20, 2025

✅ Changeset detected

Latest commit: 098e2aa

@naverpay/stylelint-config package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@naverpay/stylelint-config 🐛 Patch
powered by: naverpay changeset detect-add actions

@yujeong-jeon
Copy link
Copy Markdown
Contributor

yujeong-jeon commented May 20, 2025

Issue resolved. The problem was caused by a missing esModuleInterop field in the tsconfig.json used for the ncc build. Enabling esModuleInterop is required for correct interoperation between ESModule imports and CommonJS modules during transpilation.

@yceffort-naver
Copy link
Copy Markdown
Contributor Author

thanks @yujeong-jeon you just saved my life

@yceffort-naver
Copy link
Copy Markdown
Contributor Author

/canary-publish

@yujeong-jeon
Copy link
Copy Markdown
Contributor

yujeong-jeon commented May 20, 2025

canary-publish action can be run on main 😅

Copy link
Copy Markdown
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~!

@yujeong-jeon
Copy link
Copy Markdown
Contributor

yujeong-jeon commented May 20, 2025

thanks @yujeong-jeon you just saved my life

I don’t think that’s quite right…😂
Thanks for fixing the wrong github fetch URL!

@yceffort-naver
Copy link
Copy Markdown
Contributor Author

canary-publish action can be run on main 😅

Gooooooooo

@yceffort-naver yceffort-naver merged commit e8365ca into main May 20, 2025
3 checks passed
@yceffort-naver yceffort-naver deleted the feature/110 branch May 20, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants