Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
rigor789
left a comment
rigor789
left a comment
There was a problem hiding this comment.
ui-and-styling changes look OK, but the plugins ones will not be persisted, as they are overwritten daily form the plugins own README.md
| See [@nativescript/mlkit-core](/packages/mlkit-core/README.md) Usage | ||
|
|
||
| See [@nativescript/mlkit-core](/plugins/mlkit-core.html#core) Usage | ||
| plugins/mlkit-core.html#core |
There was a problem hiding this comment.
These changes will be overwritten from the plugins README, so would need to be made in the plugins repo instead.
There was a problem hiding this comment.
I am aware of that. You informed me about it when I made my first PR for a plugin. Thanks. Initially, I made these changes in the plugins' repo. However, when their READMEs were added to the main docs, the links broke(they only work on Github) because when you click on them from https://docs.nativescript.org/ they become https://docs.nativescript.org/packages/mlkit-core/README.html and since the packages folder is not in docs-new directory, they break. How can I make them work on both Github(when navigating from one README to another, within the same package) and https://docs.nativescript.org/?
| ## Usage | ||
|
|
||
| See [@nativescript/mlkit-core](/packages/mlkit-core/README.md) Usage | ||
| See [@nativescript/mlkit-core](/plugins/mlkit-core.html#usage) Usage |
2 participants
I fixed the
/api-reference/xxxlinks by removing.htmlwhich I think causes the links to break. I did similar changes in PR #87 but think they shouldn't wait for that PR to be merged.